Skip to content

Commit

Permalink
gh-121957: Emit audit events for python -i and python -m asyncio
Browse files Browse the repository at this point in the history
  • Loading branch information
ambv committed Jul 22, 2024
1 parent 54b5e9e commit 358afbc
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 0 deletions.
20 changes: 20 additions & 0 deletions Doc/library/asyncio.rst
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,26 @@ Additionally, there are **low-level** APIs for
* :ref:`bridge <asyncio-futures>` callback-based libraries and code
with async/await syntax.

.. _asyncio-cli:

.. rubric:: asyncio REPL

You can experiment with an ``asyncio`` concurrent context in the REPL:

.. code-block:: pycon
$ python -m asyncio
asyncio REPL ...
Use "await" directly instead of "asyncio.run()".
Type "help", "copyright", "credits" or "license" for more information.
>>> import asyncio
>>> await asyncio.sleep(10, result='hello')
'hello'
.. audit-event:: cpython.run_stdin "" ""

.. versionchanged:: 3.9.20 (also 3.8.20)
Emits audit events.

.. We use the "rubric" directive here to avoid creating
the "Reference" subsection in the TOC.
Expand Down
5 changes: 5 additions & 0 deletions Doc/using/cmdline.rst
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,11 @@ conflict.
This variable can also be modified by Python code using :data:`os.environ`
to force inspect mode on program termination.

.. audit-event:: cpython.run_stdin "" ""

.. versionchanged:: 3.9.20 (also 3.8.20)
Emits audit events.


.. envvar:: PYTHONUNBUFFERED

Expand Down
2 changes: 2 additions & 0 deletions Lib/asyncio/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ def run(self):


if __name__ == '__main__':
sys.audit("cpython.run_stdin")

loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fixed missing audit events around interactive use of Python, now also
properly firing for ``python -i``, as well as for ``python -m asyncio``. The
event in question is ``cpython.run_stdin``.
4 changes: 4 additions & 0 deletions Modules/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,10 @@ pymain_repl(PyConfig *config, PyCompilerFlags *cf, int *exitcode)
return;
}

if (PySys_Audit("cpython.run_stdin", NULL) < 0) {
return;
}

int res = PyRun_AnyFileFlags(stdin, "<stdin>", cf);
*exitcode = (res != 0);
}
Expand Down

0 comments on commit 358afbc

Please sign in to comment.