Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] gh-112769: test_zlib: test_zlib: Fix comparison of ZLIB_RUNTIME_VERSION with non-int suffix (GH-112771) #119565

Merged
merged 1 commit into from
May 28, 2024

Conversation

ned-deily
Copy link
Member

@ned-deily ned-deily commented May 25, 2024

zlib-ng defines the version as "1.3.0.zlib-ng".
(cherry picked from commit d384813)

Co-authored-by: Miro Hrončok [email protected]

…RUNTIME_VERSION with non-int suffix

zlib-ng defines the version as "1.3.0.zlib-ng".
(cherry picked from commit d384813)

Co-authored-by: Miro Hrončok [email protected]
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ned-deily for commit e0b41ff 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 25, 2024
@ned-deily ned-deily requested a review from ambv May 25, 2024 21:48
@encukou
Copy link
Member

encukou commented May 28, 2024

Thank you for getting to this, Ned!
@ambv, this test-only fix should fix the failing Fedora buildbots.

No failures are in test_zlib except the s390x builds (like this one), which is expected: on s390x zlib-ng uses hardware acceleration, which makes the compressed bits different (but still valid).

@pablogsal
Copy link
Member

Seems that Tests / macOS (pull_request) is failing

@encukou
Copy link
Member

encukou commented May 28, 2024

AFAIK it's the same failures as any other 3.10 PR -- dbm crashes on GHA.

@pablogsal
Copy link
Member

Then let's merge

@pablogsal pablogsal merged commit 48f9d3e into python:3.10 May 28, 2024
80 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants