Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.9] gh-112769: test_zlib: test_zlib: Fix comparison of ZLIB_RUNTIME_VERSION with non-int suffix (GH-112771) #119566

Merged
merged 1 commit into from
May 30, 2024
Merged

[3.9] gh-112769: test_zlib: test_zlib: Fix comparison of ZLIB_RUNTIME_VERSION with non-int suffix (GH-112771) #119566

merged 1 commit into from
May 30, 2024
+18 −12

Conversation

ned-deily
Copy link
Member

@ned-deily ned-deily commented May 25, 2024 •
edited by bedevere-app bot
Loading

zlib-ng defines the version as "1.3.0.zlib-ng".
(cherry picked from commit d384813)

Co-authored-by: Miro Hrončok [email protected]

@ned-deily
[3.9] pythongh-112769: test_zlib: test_zlib: Fix comparison of ZLIB_R…
3b9c4b6 
…UNTIME_VERSION with non-int suffix (pythonGH-112771)

zlib-ng defines the version as "1.3.0.zlib-ng".
(cherry picked from commit d384813)

Co-authored-by: Miro Hrončok [email protected]
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels May 25, 2024
This was referenced May 25, 2024
Closed
Merged
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 3b9c4b6 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2024
@encukou
Copy link
Member

encukou commented May 30, 2024

@ambv, please merge this test-only change to fix failing 3.9 buildbots.

All failures are expected/unrelated:

  • zlib-ng on s390x uses hardware acceleration, which outpots in different (but valid) bits than software zlib. That test is adjusted in later CPython versions.
  • preexisting failures: dbm crashes on macOS GHA, asyncio fails on macOS buildbot
  • usan/BSD/FIPS/nogil/wasi/iOS/win11-bigmem buildbots aren't applicable/configured/supported for 3.9

@ambv ambv merged commit 54b5e9e into python:3.9 May 30, 2024
80 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ned-deily @bedevere-bot @encukou @ambv