-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.10] gh-123270: Replaced SanitizedNames with a more surgical fix. (GH-123354) #123426
Conversation
…rgical fix. (pythonGH-123354) Applies changes from zipp 3.20.1 and jaraco/zippGH-124 (cherry picked from commit 2231286) (cherry picked from commit 17b77bb) Co-authored-by: Jason R. Coombs <[email protected]>
The tested assertions are failing in the backport on Windows:
|
Since these same tests pass on zipp on Windows+Python 3.10, it must be the case that something else has changed in zipp that wasn't backported to Python 3.10. But what? I applied the latest code from zipp to CPython, and the diff doesn't reveal anything that would explain the failing tests. |
Adding some additional information to the troubleshooting, it's slightly more clear what's happening:
|
Aha! That diff is relevant in how it handles .name on Windows ( |
@pablogsal In addition to approving/merging this security fix, I'd like your opinion. In troubleshooting why the two new tests were failing, I learned that on Python 3.10 only, I can think of a few options:
How would you like me to proceed? |
I would prefer to do that. The reason is that it's unclear if that would affect anything else and I would like more eyes on this because 3.10 it's long into security-only so I don't want to risk this. I personally would prefer to keep it consistent with 3.9 and 3.11 if it's related to the security fix but I want to see what others think |
Agree this should be patched separately. @jaraco, the security releases will go out on Friday. Would it be possible to get a fix before then? |
No problem. I'll get it done today. |
I'll revise this PR to be acceptable as-is with the expectation that the additional issue will be addressed to re-enable the tests. |
This reverts commit d1eca1e.
This patch now retains the tests but marks the two new ones as skipped on Windows, allowing the test suite to pass. A follow up GH-123694 promises to fix the emergent issue and restore the tests. |
Applies changes from zipp 3.20.1 and jaraco/zippGH-124 (cherry picked from commit 2231286) (cherry picked from commit 17b77bb)