Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-124984: Fix ssl thread safety #124993

Merged
merged 60 commits into from
Oct 19, 2024
Merged

gh-124984: Fix ssl thread safety #124993

merged 60 commits into from
Oct 19, 2024

Commits on Oct 5, 2024

  1. Make SSL objects thread safe.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    132a2dd View commit details
    Browse the repository at this point in the history

  2. Fix silly syntax errors.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    572e48f View commit details
    Browse the repository at this point in the history

  3. Fix thread safety for set_alpn_protocols

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    b0cd005 View commit details
    Browse the repository at this point in the history

  4. Fix thread safety for configure_hostname

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    0629acd View commit details
    Browse the repository at this point in the history

  5. Make some more operations atomic.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    3712d05 View commit details
    Browse the repository at this point in the history

  6. Fix thread safety with hostnames.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    eb06e05 View commit details
    Browse the repository at this point in the history

  7. Fix thread safety for BIO.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    30fce36 View commit details
    Browse the repository at this point in the history

  8. Add blurb.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    0d63bfb View commit details
    Browse the repository at this point in the history

  9. Add test.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    7268ebb View commit details
    Browse the repository at this point in the history

  10. Fix deadlock.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    28004f1 View commit details
    Browse the repository at this point in the history

  11. Remove useless locks in constructor.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    caa205a View commit details
    Browse the repository at this point in the history

  12. Zero-out locks upon initialization.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    578d40a View commit details
    Browse the repository at this point in the history

  13. Wrap lock initializations with #ifdef Py_GIL_DISABLED

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    c601906 View commit details
    Browse the repository at this point in the history

  14. Fix lock ordering deadlock.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    014a95a View commit details
    Browse the repository at this point in the history

  15. Remove lock for do_handshake()

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ebb8b40 View commit details
    Browse the repository at this point in the history

  16. Fix typo.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    a3ff154 View commit details
    Browse the repository at this point in the history

  17. Make tests better.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    591535f View commit details
    Browse the repository at this point in the history

  18. Fix tests.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    53e6d59 View commit details
    Browse the repository at this point in the history

  19. Fix missing global.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    cd047ba View commit details
    Browse the repository at this point in the history

  20. Update comment.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    3f3715b View commit details
    Browse the repository at this point in the history

  21. Update Modules/_ssl.c 

    Co-authored-by: Bénédikt Tran <[email protected]>
    @ZeroIntensity @picnixz
    ZeroIntensity and picnixz authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    d808932 View commit details
    Browse the repository at this point in the history

  22. Update Modules/_ssl.c 

    Co-authored-by: Bénédikt Tran <[email protected]>
    @ZeroIntensity @picnixz
    ZeroIntensity and picnixz authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    df26ffe View commit details
    Browse the repository at this point in the history

  23. Merge branch 'fix-ssl-threadsafety' of https://github.com/ZeroIntensi… 

    …ty/cpython into fix-ssl-threadsafety
    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    288c9a3 View commit details
    Browse the repository at this point in the history

  24. Don't lock Py* functions.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    c8df918 View commit details
    Browse the repository at this point in the history

  25. Clarify comment.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    23aa4f9 View commit details
    Browse the repository at this point in the history

  26. Remove useless functions in threaded tests and lower number of threads.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    92d9525 View commit details
    Browse the repository at this point in the history

  27. Remove more useless functions.

    @ZeroIntensity
    ZeroIntensity committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    eff01db View commit details
    Browse the repository at this point in the history

  28. Add note about thread count

    @ZeroIntensity
    ZeroIntensity authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    f678df1 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Clarify news entry.

    @ZeroIntensity
    ZeroIntensity committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e96bf31 View commit details
    Browse the repository at this point in the history

  2. Remove lock for deallocator.

    @ZeroIntensity
    ZeroIntensity committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    028bb6a View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Remove PySSL_LOCK() and PySSL_UNLOCK()

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f578c8e View commit details
    Browse the repository at this point in the history

  2. Use argument clinic for critical sections.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    80aea32 View commit details
    Browse the repository at this point in the history

  3. Switch reused_session to clinic

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7d76621 View commit details
    Browse the repository at this point in the history

  4. Switch session to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    44a8c48 View commit details
    Browse the repository at this point in the history

  5. Switch owner to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6e13fed View commit details
    Browse the repository at this point in the history

  6. Switch server_hostname to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2424f67 View commit details
    Browse the repository at this point in the history

  7. Switch context to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9b91bc0 View commit details
    Browse the repository at this point in the history

  8. Switch check_hostname to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c0377eb View commit details
    Browse the repository at this point in the history

  9. Switch host_flags to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    be02857 View commit details
    Browse the repository at this point in the history

  10. Switch minimum_version to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fe362d4 View commit details
    Browse the repository at this point in the history

  11. Switch maximum_version to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fe088d6 View commit details
    Browse the repository at this point in the history

  12. Switch sni_callback to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f9ae852 View commit details
    Browse the repository at this point in the history

  13. Switch num_tickets to clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    eb61a84 View commit details
    Browse the repository at this point in the history

  14. Switch options to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b9c2732 View commit details
    Browse the repository at this point in the history

  15. Switch protocol to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ae25f65 View commit details
    Browse the repository at this point in the history

  16. Switch verify_flags to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4950f45 View commit details
    Browse the repository at this point in the history

  17. Switch verify_mode to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fee2d4f View commit details
    Browse the repository at this point in the history

  18. Switch security_level to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6449c95 View commit details
    Browse the repository at this point in the history

  19. Switch MemoryBIO to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a0fc838 View commit details
    Browse the repository at this point in the history

  20. Switch has_ticket to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8c4e20d View commit details
    Browse the repository at this point in the history

  21. Switch session_id to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    44f1782 View commit details
    Browse the repository at this point in the history

  22. Switch ticket_lifetime_hint to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    216c318 View commit details
    Browse the repository at this point in the history

  23. Switch time to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    701bf00 View commit details
    Browse the repository at this point in the history

  24. Switch timeout to argument clinic.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ffc4879 View commit details
    Browse the repository at this point in the history

  25. Fix name inconsistency.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ebd621b View commit details
    Browse the repository at this point in the history

  26. Fix build complaints.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3b81e78 View commit details
    Browse the repository at this point in the history

  27. Fix more build complaints.

    @ZeroIntensity
    ZeroIntensity committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e7e0f47 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Fix failing builds.

    @ZeroIntensity
    ZeroIntensity committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8cf4992 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Clarify comment and use catch_threading_exception()

    @ZeroIntensity
    ZeroIntensity committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d9152af View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Check for SkipTest in exc_value.

    @ZeroIntensity
    ZeroIntensity committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    07f848c View commit details
    Browse the repository at this point in the history