-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-125038: Crash after genexpr.gi_frame.f_locals manipulations is fixed #125178
Changes from 8 commits
3dd0feb
f54918c
9665d13
233f6b6
ca04eef
b94d5c4
385b389
7aa00b4
890b936
d75a476
f93e8cd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markshannon while this is fine for 3.14, the idea is to backport this change to 3.13. Are you sure it's OK to bump the magic number in a bugfix release? I looked through the 3.8 through 3.12 branches (e.g., https://github.com/python/cpython/blob/3.8/Lib/importlib/_bootstrap_external.py) and we never bumped the magic number after the beta phase. This could cause problems for people who distribute applications as pyc files.