gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash #125477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mdboom
commented
Oct 14, 2024
•
mdboom
commented
- Issue: Compiler crash on MSVC when building with JIT and PGO #125217
mdboom
commented
Oct 14, 2024
.github/workflows/jit.yml
Outdated
| @@ -41,7 +41,6 @@ jobs: | |||
| ./python -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3 | |||
| jit: | |||
| name: ${{ matrix.target }} (${{ matrix.debug && 'Debug' || 'Release' }}) | |||
| needs: interpreter | |||
There was a problem hiding this comment.
Removing the requirement on the Tier 2 interpreter pass here, since it seems to be failing consistently on test.test_asyncio.test_taskgroups, and I'm not sure that's relevant to this PR.
There was a problem hiding this comment.
Ah, thanks. We won't merge these changes, then, but it's useful for now to illustrate that the fix here works.
… to avoid MSVC crash
mdboom
force-pushed
the
disable-interpreter-optimizations-when-jit-enabled
branch
from
bfcfe72
to
8340829
Compare
mdboom
commented
Oct 15, 2024
Python/jit.c
Outdated
| @@ -18,6 +18,7 @@ | |||
| #include "pycore_sliceobject.h" | |||
| #include "pycore_jit.h" | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This is to trigger the JIT CI, but I can remove this commit before merging.
brandtbucher
approved these changes
Oct 15, 2024
mdboom
force-pushed
the
disable-interpreter-optimizations-when-jit-enabled
branch
from
a55510c
to
8340829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.