Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-125832: Clarify comment for inlined comprehensions as per PEP-709 #126322

Merged
merged 3 commits into from
Nov 2, 2024
Merged

gh-125832: Clarify comment for inlined comprehensions as per PEP-709 #126322

merged 3 commits into from
Nov 2, 2024

Conversation

rimi0108
Copy link
Contributor

@rimi0108 rimi0108 commented Nov 2, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 2, 2024
Closed
@rimi0108
Copy link
Contributor Author

rimi0108 commented Nov 2, 2024

@corona10

@corona10
Copy link
Member

corona10 commented Nov 2, 2024 •
edited
Loading

@carljm @willingc Would you like to take a look?
Carl, FYI, Hyerim Choi is the participant in this year's PyCon KR Sprint :)

rruuaanng
rruuaanng reviewed Nov 2, 2024
View reviewed changes
Python/codegen.c Outdated Show resolved Hide resolved
@picnixz picnixz changed the title gh-125832: Fix comprehensions comment to inlined by pep 709 gh-125832: Clarify comment for inlined comprehensions as per PEP-709 Nov 2, 2024
@willingc @rruuaanng
Update spacing
bc40dc0 
Co-authored-by: RUANG (James Roy) <[email protected]>
willingc
willingc approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have one suggestion to add a reference to PEP 709

Python/codegen.c Show resolved Hide resolved
@willingc
Copy link
Contributor

willingc commented Nov 2, 2024

Congrats @rimi0108 on the contribution during the sprint. 🎉 cc/ @corona10 nice mentoring.

@willingc willingc enabled auto-merge (squash) November 2, 2024 16:41
@willingc willingc merged commit 868bfcc into python:main Nov 2, 2024
37 checks passed
@picnixz
Copy link
Contributor

picnixz commented Nov 2, 2024 •
edited
Loading

I think this one can be backported to 3.12 since PEP-709 was for 3.12 (or maybe 3.13 only?), right?

@willingc
Copy link
Contributor

willingc commented Nov 2, 2024

@picnixz Yep. 3.12 and 3.13. Thanks!

@picnixz picnixz added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 2, 2024
@miss-islington-app
Copy link

Thanks @rimi0108 for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @rimi0108 for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @rimi0108 and @willingc, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 868bfcc02ed42a1042851830b79c6877b7f1c7a8 3.12

@miss-islington-app
Copy link

Sorry, @rimi0108 and @willingc, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 868bfcc02ed42a1042851830b79c6877b7f1c7a8 3.13

@bedevere-app
Copy link

bedevere-app bot commented Nov 3, 2024

GH-126344 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 3, 2024
corona10 pushed a commit to corona10/cpython that referenced this pull request Nov 3, 2024
@rimi0108 @corona10
pythongh-125832: Clarify comment for inlined comprehensions as per PE…
62ddc5f 
…P-709 (python#126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <[email protected]>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
(cherry picked from commit 868bfcc)
corona10 pushed a commit to corona10/cpython that referenced this pull request Nov 3, 2024
@rimi0108 @willingc
@rruuaanng @corona10
[3.12] pythongh-125832: Clarify comment for inlined comprehensions as…
c7a3bbe 
… per PEP-709 (pythongh-126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <[email protected]>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
@corona10 corona10 mentioned this pull request Nov 3, 2024
Merged
@bedevere-app
Copy link

bedevere-app bot commented Nov 3, 2024

GH-126345 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 3, 2024
corona10 added a commit that referenced this pull request Nov 3, 2024
@corona10 @rimi0108
@willingc @rruuaanng
[3.12] gh-125832: Clarify comment for inlined comprehensions as per P… (
4afa129 
gh-126345)

* [3.12] gh-125832: Clarify comment for inlined comprehensions as per PEP-709 (gh-126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <[email protected]>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>

* Add space

---------

Co-authored-by: rimchoi <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
corona10 added a commit that referenced this pull request Nov 3, 2024
@corona10 @rimi0108
[3.13] gh-125832: Clarify comment for inlined comprehensions as per P…
36079f7 
…EP-709 (gh-126322) (gh-126344)

* gh-125832: Clarify comment for inlined comprehensions as per PEP-709 (#126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <[email protected]>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
(cherry picked from commit 868bfcc)

* Add space

---------

Co-authored-by: rimchoi <[email protected]>
@carljm
Copy link
Member

carljm commented Nov 4, 2024

Sorry, I wasn't available over the weekend, but this change looks good to me! Thank you @rimi0108 for the PR and @willingc for reviewing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rruuaanng rruuaanng rruuaanng left review comments

@willingc willingc willingc approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@carljm carljm Awaiting requested review from carljm

Assignees

@willingc willingc

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rimi0108 @corona10 @willingc @picnixz @carljm @rruuaanng