Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-125761: Clarify repeated warning suppression criteria in warnings module #126326

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

byungchanKo99
Copy link
Contributor

@byungchanKo99 byungchanKo99 commented Nov 2, 2024

Copy link

cpython-cla-bot bot commented Nov 2, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@corona10
Copy link
Member

corona10 commented Nov 2, 2024

@ncoghlan Would you like to take a look at this PR?
FYI, @byungchanKo99 is the first-time contributor who is participating in the PyCon KR 2024 sprint today.

Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@ncoghlan ncoghlan added 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 2, 2024
@ncoghlan ncoghlan merged commit 10eeec2 into python:main Nov 2, 2024
46 checks passed
@miss-islington-app
Copy link

Thanks @byungchanKo99 for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2024
…nings module (pythongh-126326)

(cherry picked from commit 10eeec2)

Co-authored-by: 고병찬 <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2024
…nings module (pythongh-126326)

(cherry picked from commit 10eeec2)

Co-authored-by: 고병찬 <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 2, 2024

GH-126330 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 2, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 2, 2024

GH-126331 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants