Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Delist default sqlite3 adapters and convertors deprecation from "Pending removal in 3.14" #126370

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 3, 2024

This was deprecated in 3.12 (#94276) but never planned to be removed in 3.14. It was added to the "Pending removal in Python 3.14" list by mistake, probably assuming it would be removed in +2 releases.

https://docs.python.org/3.13/library/sqlite3.html#default-adapters-and-converters-deprecated is correct: only says deprecated in 3.12.

See also https://discuss.python.org/t/deprecate-default-built-in-sqlite3-converters-and-adapters/15781.


📚 Documentation preview 📚: https://cpython-previews--126370.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting core review labels Nov 3, 2024
@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes skip issue docs Documentation in the Doc dir awaiting core review skip news and removed docs Documentation in the Doc dir awaiting core review skip news labels Nov 3, 2024
@hugovk hugovk changed the title Docs: remove sqlite3 deprecation with no pending removal date Docs: Delist sqlite3 deprecation from "Pending removal in 3.14" Nov 3, 2024
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk enabled auto-merge (squash) November 3, 2024 21:15
@hugovk hugovk merged commit 9441993 into python:main Nov 3, 2024
56 checks passed
@hugovk hugovk deleted the rm-sqlite3-pending branch November 3, 2024 21:22
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 3, 2024

GH-126372 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 3, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 3, 2024

GH-126373 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 3, 2024
hugovk added a commit that referenced this pull request Nov 3, 2024
hugovk added a commit that referenced this pull request Nov 3, 2024
@Wulian233
Copy link
Contributor

Should we add it to pending remove in future.rst?

@erlend-aasland
Copy link
Contributor

Should we add it to pending remove in future.rst?

No; it is not pending removal at all.

@gpshead gpshead changed the title Docs: Delist sqlite3 deprecation from "Pending removal in 3.14" Docs: Delist default sqlite3 adapters and convertors deprecation from "Pending removal in 3.14" Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants