Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126374: Add support of options with optional arguments in the getopt module #126375

Merged
merged 5 commits into from
Nov 11, 2024
Merged

gh-126374: Add support of options with optional arguments in the getopt module #126375

merged 5 commits into from
Nov 11, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 3, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 3, 2024
Closed
brianschubert
brianschubert reviewed Nov 3, 2024
View reviewed changes
Doc/library/getopt.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2024-11-03-23-25-07.gh-issue-126374.Xu_THP.rst Outdated Show resolved Hide resolved
@serhiy-storchaka
Copy link
Member Author

Thank you for your suggestions @brianschubert.

@serhiy-storchaka @erlend-aasland
Update Doc/library/getopt.rst
efc63db 
Co-authored-by: Erlend E. Aasland <[email protected]>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 6, 2024
Merged
@serhiy-storchaka serhiy-storchaka merged commit 25aee21 into python:main Nov 11, 2024
36 checks passed
@serhiy-storchaka serhiy-storchaka deleted the getopt-optional branch November 11, 2024 16:29
@brianschubert
Copy link
Contributor

Sorry if I'm missing some context, but since this is a new feature, shouldn't it have gotten at least one green-check review before being merged?

Per Workflow change coming: mandatory reviews on new features

@gpshead gpshead added the type-feature A feature request or enhancement label Nov 13, 2024
@gpshead
Copy link
Member

gpshead commented Nov 13, 2024

Sorry if I'm missing some context, but since this is a new feature, shouldn't it have gotten at least one green-check review before being merged?

Technically yes. Our automation cannot detect and label such things accurately. LGTM on this change. For what its worth I had seen these changes as part of #126393 (which was stacked on top of this) prior to this and was happy with them; Serhiy answered a question I had left there on what turned out to be this PRs changes. we just hadn't connected all the dots to make that obvious on github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianschubert brianschubert brianschubert left review comments

@erlend-aasland erlend-aasland erlend-aasland left review comments

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @brianschubert @gpshead @erlend-aasland