Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14 #126392

Merged
merged 1 commit into from
Nov 4, 2024
Merged

gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14 #126392

merged 1 commit into from
Nov 4, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 4, 2024 •
edited by bedevere-app bot
Loading

There's still quite a bit of use in the wild and we're in no rush to remove this in Python 3.14.

Let's bump to 3.15 and reassess during the next cycle.

📚 Documentation preview 📚: https://cpython-previews--126392.org.readthedocs.build/

@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 4, 2024
@hugovk hugovk requested a review from willingc as a code owner November 4, 2024 11:10
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting core review labels Nov 4, 2024
@hugovk hugovk changed the title gh-101866: Docs: Keep co_lnotab deprecation for at least 3.14 gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14 Nov 4, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 4, 2024
Closed
AlexWaygood
AlexWaygood approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's unlikely this will be removed while it's still in use by pytorch, huggingface, and many others. So I'd also be okay with changing the deprecation notice to an undefined removal date for now. But at the same time, it's less likely that they'll ever remove their uses of co_lnotab unless there is a removal date, so this is also fine!

sobolevn
sobolevn approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@encukou
Copy link
Member

encukou commented Nov 4, 2024

Why not “maybe someday” rather than 3.15? To me it seems that not breaking things would save effort on both sides.

@markshannon
Copy link
Member

While we could delay this indefinitely, we should encourage users to move as sooner rather than later.

Using co_lnotab for picking is pointless as co_linetable contains all the information.
If it is being used to find line numbers, it is far more efficient to use co_lines or co_positions.

willingc
willingc approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @hugovk. Thanks.

@hugovk
Copy link
Member Author

hugovk commented Nov 4, 2024

And I the wording is now all "May be removed in ..." instead of 2x that and 1x "therefore it will be removed in ..."

@hugovk hugovk merged commit eac41c5 into python:main Nov 4, 2024
40 checks passed
@hugovk hugovk deleted the docs-co_lnotab-3.15 branch November 4, 2024 16:50
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker eac41c5ddfadf52fbd84ee898ad56aedd5d90a41 3.13

@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker eac41c5ddfadf52fbd84ee898ad56aedd5d90a41 3.12

hugovk added a commit to hugovk/cpython that referenced this pull request Nov 4, 2024
@hugovk
[3.13] pythongh-101865: Docs: Keep co_lnotab deprecation for at least…
5ee730c 
… 3.14 (pythonGH-126392)

(cherry picked from commit eac41c5)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 4, 2024

GH-126403 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 4, 2024
hugovk added a commit to hugovk/cpython that referenced this pull request Nov 4, 2024
@hugovk
[3.12] pythongh-101865: Docs: Keep co_lnotab deprecation for at least…
5e90e7f 
… 3.14 (pythonGH-126392)

(cherry picked from commit eac41c5)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 4, 2024

GH-126404 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 4, 2024
hugovk added a commit that referenced this pull request Nov 4, 2024
@hugovk
[3.13] gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14 (G…
cccc066 
…H-126392) (#126403)

(cherry picked from commit eac41c5)
hugovk added a commit that referenced this pull request Nov 4, 2024
@hugovk
[3.12] gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14 (G…
94423b6 
…H-126392) (#126404)

(cherry picked from commit eac41c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@sobolevn sobolevn sobolevn approved these changes

@willingc willingc willingc approved these changes

Assignees

@hugovk hugovk

Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugovk @encukou @markshannon @willingc @sobolevn @AlexWaygood