-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: re-create pages for removed modules to document their removal. #126622
Conversation
This shows just two modules as an example. Will flesh it out with the rest of PEP 594 if people like the approach. Will also need to change the redirects that were created here: https://github.com/python/psf-salt/pull/521/files
Please re-evaluate if recommending
Disclaimer: I'm the author of the multipart library. |
Thanks. I copied those recommendations from the What's New section when the module was removed. I can omit this part of the page and let people find other advice to follow. We should also make clear (as someone mentioned in Discourse) that the PyPI packages are third-party, not maintained by the CPython team.
I'm not sure how else you would like it to be mentioned. The first sentence (and soon one of the only sentences) is very clear. |
I would just like it to stand out more by using the |
77a7a09
to
7fcf162
Compare
I've added the |
I've added the rest of the PEP 594 modules. Any last concerns? |
Any chance of adding distutils (PEP 632)? |
I guess also |
Ah, yeah, |
I've added distutils and imp. |
|
||
This module is no longer part of the Python standard library. | ||
It was :ref:`removed in Python 3.12 <whatsnew312-removed>` after | ||
being deprecated in Python 3.4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No mention of importlib as replacement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I added a mention that the removal notice on the What's New page includes the migration advice.
66784f8
to
002be87
Compare
Thanks @nedbat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ythonGH-126622) Will also need to change the redirects that were created here: https://github.com/python/psf-salt/pull/521/files (cherry picked from commit 036930d) Co-authored-by: Ned Batchelder <[email protected]>
GH-126709 is a backport of this pull request to the 3.13 branch. |
@nedbat do you intend to backport this to 3.12? Otherwise we shall need to retain the redirects for asynchat, asyncore, and smtpd in the 3.12 documentation only. A |
Most of the modules were removed in 3.13, so it's better to leave 3.12 as it is. |
There are ~5 from 3.12, so I'd say it's worth considering if the 'version switcher' case is to be useful -- but if not I shall update the redirects PR accordingly. A |
The modules removed in 3.12 as asynchat, asyncore, distutils, imp, and smtpd. To make those behave correctly, we'd need a new PR for the docs that we'd only apply to the 3.12 branch, correct? |
I don't think you'd need a new PR, just backporting this one and deleting the PEP 594 changes should work, I believe. Though maybe avoiding cherry picker would be less work, I'm not sure. A |
#126781 has the changes needed for 3.12. |
This shows just two modules as an example. Will flesh it out with the rest of PEP 594 if people like the approach.This adds a "Removed modules" page that lists modules which have been removed. Each module gets a page (with the original URL) that explains why the module is gone.
Will also need to change the redirects that were created here: https://github.com/python/psf-salt/pull/521/files
Things to notice:
Where existing suggested replacements text was available, I've put it on the removed module page.📚 Documentation preview 📚: https://cpython-previews--126622.org.readthedocs.build/