Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126594: Fix typeobject.c wrap_buffer() cast #126754

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-126594: Fix typeobject.c wrap_buffer() cast #126754

wants to merge 2 commits into from
+3 −3

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 12, 2024 •
edited by bedevere-app bot
Loading

@vstinner
pythongh-126594: Fix typeobject.c wrap_buffer() cast
019df14 
Reject flags smaller than INT_MIN.
@vstinner vstinner added skip news needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 12, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 12, 2024
Open
@vstinner
Copy link
Member Author

@JelleZijlstra: Do you want to review this change?

JelleZijlstra
JelleZijlstra reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth adding a test? I understand this condition can perhaps only be triggered on some platforms.

Objects/typeobject.c Outdated Show resolved Hide resolved
@vstinner @JelleZijlstra
Update Objects/typeobject.c
9a6bcc7 
Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @JelleZijlstra