-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-12403: Mention sys.displayhook in code module docs and the compile builtin docs #26217
base: main
Are you sure you want to change the base?
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This PR is stale because it has been open for 30 days with no activity. |
Doc/library/code.rst
Outdated
* Exception tracebacks and syntax errors are written to :data:`sys.stderr` by | ||
default but can be redirected by setting :func:`sys.excepthook`. | ||
All output is printed to :data:`sys.stderr` by default. A user can override | ||
:meth:`InteractiveConsole.write` in a derived class to change that. Alternatively, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wrap this so that no line is more than 80 chars.
Before we make this documented behavior, let's make sure that there are unit tests ensuring it is true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are tests for excepthook, but not for displayhook:
https://github.com/python/cpython/blob/main/Lib/test/test_code_module.py
Misc/NEWS.d/next/Documentation/2021-05-25-20-35-37.bpo-12403.8BFtwS.rst
Outdated
Show resolved
Hide resolved
…BFtwS.rst Co-authored-by: Irit Katriel <[email protected]>
Co-authored-by: Irit Katriel <[email protected]>
This reverts commit 5130904. My bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
:meth:`InteractiveConsole.write` in a derived class to change that. | ||
Alternatively, it is possible to selectively redirect parts of the output: | ||
|
||
* The return values of successfully interpreted Python statements are printed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is technically incorrect; statements don't have return values. I suppose it means the evaluated value of ast.Expr
statements.
This includes the patch submitted in the issue, and the wording suggested by @iritkatriel .
https://bugs.python.org/issue12403
Co-authored-by: Aaron Iles [email protected]
https://bugs.python.org/issue12403