Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-12403: Mention sys.displayhook in code module docs and the compile builtin docs #26217

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

normanlorrain
Copy link

@normanlorrain normanlorrain commented May 18, 2021

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@normanlorrain

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 25, 2021
* Exception tracebacks and syntax errors are written to :data:`sys.stderr` by
default but can be redirected by setting :func:`sys.excepthook`.
All output is printed to :data:`sys.stderr` by default. A user can override
:meth:`InteractiveConsole.write` in a derived class to change that. Alternatively,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap this so that no line is more than 80 chars.

Before we make this documented behavior, let's make sure that there are unit tests ensuring it is true.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are tests for excepthook, but not for displayhook:
https://github.com/python/cpython/blob/main/Lib/test/test_code_module.py

Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

:meth:`InteractiveConsole.write` in a derived class to change that.
Alternatively, it is possible to selectively redirect parts of the output:

* The return values of successfully interpreted Python statements are printed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is technically incorrect; statements don't have return values. I suppose it means the evaluated value of ast.Expr statements.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 8, 2022
@willingc willingc added stale Stale PR or inactive for long period of time. awaiting changes and removed awaiting core review labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes docs Documentation in the Doc dir stale Stale PR or inactive for long period of time.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

8 participants