s2clientprotocol stubs #10372
s2clientprotocol stubs #10372
Conversation
Stubs were generated using protoc version 3.4.0 and mypy-protobuf.
This comment has been minimized.
This comment has been minimized.
Constrain to version 5.* as that is the current of s2clientprotocol which is being published. The protobuf version is constrained to <4 for compatability reasons. While it is unpinned in the requires for s2clientprotocol, all downstream users actually need to end up pinning to <4 as the protoc version (3.4.0) generates proto2 messages, which raise runtime errors when used with protobuf>=4.
jrtknauer
force-pushed
the
s2clientprotocol-stubs
branch
from
3695433 to
ce461e8
Compare
|
(Nit: no need to force-push on a typeshed PR. We merge all PRs using GitHub's "squash and merge" button, so we don't really care about a clean commit history, and force pushes tend to make it harder for us to see what changed in between commits :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Thanks, and sorry for the delay! Stubtest struggles a bit with this package, so I've had to add all the generated files to the stubtest allowlist. We already do this quite extensively for other stubs packages that we generate using mypy-protobuf, though, so I'm fine with that. mypy-protobuf generally generates pretty good stubs that users seem to be happy with!
|
No worries. In the interim I have been building the protos and stubs in-project, but there are other |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
These stubs were added yesterday in #10372, and I forgot that we had just added this new metadata field
These stubs were added yesterday in #10372, and I forgot that we had just added this new metadata field
With the type stubs for s2clientprotocol now available in typeshed [1], compiling the protocol buffers and the types from the s2client-proto submodule is no longer necessary. References: [1] python/typeshed#10372
With the type stubs for s2clientprotocol now available in typeshed [1], compiling the protocol buffers and the types from the s2client-proto submodule is no longer necessary. References: [1] python/typeshed#10372
With the type stubs for s2clientprotocol now available in typeshed [1], compiling the protocol buffers and the types from the s2client-proto submodule is no longer necessary. References: [1] python/typeshed#10372
Motivation
Fixes #10371. Should the
s2client-protomaintainers respond to and merge my PR as part of the package, then inclusion of the stubs here would no longer be necessary. However, the maintainers do not seem to be particularly active, so I believe it would be better to get the stubs working here first (if it is possible to overlook the discrepencies in the third party stub test).