-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specs clarification: Forbid ClassVar
and Final
within TypedDict
body
#1890
Conversation
I'd prefer to approach this by being precise about where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this could still be phrased in a more general way, but we can change that later.
Is there anything else need to be done here? |
* main: (29 commits) Updated conformance test results for the latest versions of type chec… (python#1904) Add content from typeshed/CONTRIBUTING.md (python#1882) Fix markup in generics specification (python#1900) Specs clarification: Forbid `ClassVar` and `Final` within `TypedDict` body (python#1890) Remove paragraph mentioning minor edits through the mailing list (python#1891) Writing Stubs: Add "Overloads and Flags" section (python#1894) Fix a typo (python#1893) Update conformance tests for recent generics spec change (python#1892) Clarify some behavior around user-defined generic classes (python#1879) Modernizing guide: Mention TypeGuard/TypeIs (python#1887) Tools can perform "some" refactorings (python#1886) Mention use of cast in enum type stub example (python#1877) Update conformance results after new pyre release (python#1878) Add a label for typed dictionaries class-based syntax (python#1873) Add missing return type to generic_syntax_infer_variance.py (python#1871) Updated conformance results for mypy 1.13 and pyright 1.1.386 (python#1870) Modernizing guide: also mention `com2ann` (python#1869) Suggest `pyupgrade` or `ruff` for modernizing superseded typing features (python#1868) Updated conformance results for pyright 1.1.385. (python#1867) Updated conformance results for mypy 1.12. (python#1866) ...
TypedDict
to have aClassVar
field?ClassVar
andFinal
withinTypedDict
At runtime, both
ClassVar
andFinal
are not recognized as valid qualifiers forTypedDict
items: