Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs clarification: Forbid ClassVar and Final within TypedDict body #1890

Merged
merged 4 commits into from
Dec 8, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

@InSyncWithFoo InSyncWithFoo commented Dec 1, 2024

At runtime, both ClassVar and Final are not recognized as valid qualifiers for TypedDict items:

>>> from typing import TypedDict, ClassVar, Final
>>> class D(TypedDict):
...     a: ClassVar[int]
...
[truncated]
TypeError: typing.ClassVar[int] is not valid as type argument
>>> class D(TypedDict):
...     a: Final[int]
...
[truncated]
TypeError: typing.Final[int] is not valid as type argument

@JelleZijlstra
Copy link
Member

I'd prefer to approach this by being precise about where ClassVar and Final are allowed, as opposed to saying something specific to TypedDicts. For example, are they allowed in NamedTuple bodies?

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this could still be phrased in a more general way, but we can change that later.

@InSyncWithFoo
Copy link
Contributor Author

Is there anything else need to be done here?

@carljm carljm merged commit 6dd6fe4 into python:main Dec 8, 2024
4 checks passed
carljm added a commit to erictraut/typing that referenced this pull request Jan 9, 2025
* main: (29 commits)
  Updated conformance test results for the latest versions of type chec… (python#1904)
  Add content from typeshed/CONTRIBUTING.md (python#1882)
  Fix markup in generics specification (python#1900)
  Specs clarification: Forbid `ClassVar` and `Final` within `TypedDict` body (python#1890)
  Remove paragraph mentioning minor edits through the mailing list (python#1891)
  Writing Stubs: Add "Overloads and Flags" section (python#1894)
  Fix a typo (python#1893)
  Update conformance tests for recent generics spec change (python#1892)
  Clarify some behavior around user-defined generic classes (python#1879)
  Modernizing guide: Mention TypeGuard/TypeIs (python#1887)
  Tools can perform "some" refactorings (python#1886)
  Mention use of cast in enum type stub example (python#1877)
  Update conformance results after new pyre release (python#1878)
  Add a label for typed dictionaries class-based syntax (python#1873)
  Add missing return type to generic_syntax_infer_variance.py (python#1871)
  Updated conformance results for mypy 1.13 and pyright 1.1.386 (python#1870)
  Modernizing guide: also mention `com2ann` (python#1869)
  Suggest `pyupgrade` or `ruff` for modernizing superseded typing features (python#1868)
  Updated conformance results for pyright 1.1.385. (python#1867)
  Updated conformance results for mypy 1.12. (python#1866)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants