Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

third-party test: Update Python versions #484

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Oct 11, 2024

Drop 3.8. One of them (pyanalyze) already dropped support for 3.8, and
likely others will follow soon. I'd like to wait a bit to drop support
in typing-extensions itself, but I'm no longer interested in how 3.8
works in third-party packages.

Also add 3.12 and 3.13 for all of them. If any don't work, I'll drop
them again.

Fixes #483.

Drop 3.8. One of them (pyanalyze) already dropped support for 3.8, and
likely others will follow soon. I'd like to wait a bit to drop support
in typing-extensions itself, but I'm no longer interested in how 3.8
works in third-party packages.

Also add 3.12 and 3.13 for all of them. If any don't work, I'll drop
them again.
@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Oct 11, 2024

Wow, kind of sad for 3.13 (pyanalyze needs asynq, cattrs needs msgspec, typeguard and typed-argument-parser just seem unhappy, although it does look like you added 3.13 support to typeguard)

@JelleZijlstra
Copy link
Member Author

I think I can fix the typeguard thing by turning off colors, pushing in a moment

@@ -340,7 +343,8 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
# skip 3.13 because msgspec doesn't support 3.13 yet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -137,7 +137,8 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
# 3.13 support is pending
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hauntsaninja hauntsaninja merged commit 17d3a37 into python:main Oct 11, 2024
54 checks passed
@JelleZijlstra JelleZijlstra deleted the bye38 branch October 11, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Third-party tests failed on Fri Oct 11 2024
2 participants