Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype: Scary Vec2s and Nice Sprites #2219

Draft
wants to merge 29 commits into
base: development
Choose a base branch
from
Draft

Prototype: Scary Vec2s and Nice Sprites #2219

wants to merge 29 commits into from

Commits on Jul 26, 2024

  1. Replace parts of BasicSprite via Vec2 + shim props

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1b5c70d View commit details
    Browse the repository at this point in the history

  2. First pass of Vec2-ing

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    35fc6cd View commit details
    Browse the repository at this point in the history

  3. development-portable optimization: stop having 2 levels of indirectio… 

    …n for change_*
    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c62bc5e View commit details
    Browse the repository at this point in the history

  4. Make .velocity return Vec2

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    678918a View commit details
    Browse the repository at this point in the history

  5. Make stop set a Vec2 w/o indirection

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c8f36cd View commit details
    Browse the repository at this point in the history

  6. Get more types correct + some micro cleanup per Dragon's advice

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    2b90284 View commit details
    Browse the repository at this point in the history

  7. Update for sprites now takes dt

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a2dab4b View commit details
    Browse the repository at this point in the history

  8. Clean up use of ._width in width setter

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1e48567 View commit details
    Browse the repository at this point in the history

  9. Clean up use of self._height in height property

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    45684c7 View commit details
    Browse the repository at this point in the history

  10. scale_y setter consistency tweak

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b54e852 View commit details
    Browse the repository at this point in the history

  11. Inline center_x position updates

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0cdf2a2 View commit details
    Browse the repository at this point in the history

  12. Inline center_y position update

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    aac2ab0 View commit details
    Browse the repository at this point in the history

  13. Tweaks to size setter 

    * Keep unpack at top and old-style check

* Defer Vec2 creation until know it's different
    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0a7ea89 View commit details
    Browse the repository at this point in the history

  14. Replace _height usage in scale_y setter

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    998cba3 View commit details
    Browse the repository at this point in the history

  15. Remove redundant Vec2 conversion in scale getter

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    7d2cc9b View commit details
    Browse the repository at this point in the history

  16. Defer Vec2 allocation until after equality check in scale setter

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    40d5d7d View commit details
    Browse the repository at this point in the history

  17. Comment on strangeness in redundant sprite list updates

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    faa2eed View commit details
    Browse the repository at this point in the history

  18. Fix pyright compat issue due to name reassign

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    8923143 View commit details
    Browse the repository at this point in the history

  19. Fix pyright issue and bug in scaling

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    eceb22f View commit details
    Browse the repository at this point in the history

  20. Fix more type issues

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    91a691d View commit details
    Browse the repository at this point in the history

  21. Remove redundant scale setting

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    43027fe View commit details
    Browse the repository at this point in the history

  22. Fix texture setter

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    598acbe View commit details
    Browse the repository at this point in the history

  23. pyright rmul workaround

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    fd16294 View commit details
    Browse the repository at this point in the history

  24. Formatting with ./make.py format

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    5d65be0 View commit details
    Browse the repository at this point in the history

  25. Use early return suggestion from @DragonMoffon

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    46b10ac View commit details
    Browse the repository at this point in the history

  26. Apply suggestion from @DragonMoffon in height.setter

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    60535fc View commit details
    Browse the repository at this point in the history

  27. Apply same early return style in size.setter

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b428d1a View commit details
    Browse the repository at this point in the history

  28. Formatting

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    fbe9050 View commit details
    Browse the repository at this point in the history

  29. Replace variable re-assignment with local variable typed purely to Vec2

    @pushfoo
    pushfoo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    e168e82 View commit details
    Browse the repository at this point in the history