Fix multiline string properties (#75)

* Test for multiline object properties. * Fix parsing of multiline string properties.
pythonarcade · Oct 3, 2024 · dd4cd1d · dd4cd1d
1 parent 31458e0
commit dd4cd1d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/pytiled_parser/parsers/tmx/properties.py b/pytiled_parser/parsers/tmx/properties.py
@@ -12,11 +12,10 @@ def parse(raw_properties: etree.Element) -> Properties:
     for raw_property in raw_properties.findall("property"):
         type_ = raw_property.attrib.get("type")
 
-        if "value" not in raw_property.attrib:
+        value_ = raw_property.attrib.get("value", raw_property.text)
+        if value_ is None:
             continue
 
-        value_ = raw_property.attrib["value"]
-
         if type_ == "file":
             value = Path(value_)
         elif type_ == "color":

diff --git a/tests/test_tiled_object_tmx.py b/tests/test_tiled_object_tmx.py
@@ -129,6 +129,9 @@
           <property name="float property" type="float" value="42.1"/>
           <property name="int property" type="int" value="8675309"/>
           <property name="string property" value="pytiled_parser rulez!1!!"/>
+          <property name="multiline string property">Hi
+I can write multiple lines in here
+That's pretty great</property>
          </properties>
         </object>
         """,
@@ -144,6 +147,7 @@
                 "float property": 42.1,
                 "int property": 8675309,
                 "string property": "pytiled_parser rulez!1!!",
+                "multiline string property": "Hi\nI can write multiple lines in here\nThat's pretty great",
             },
         ),
     ),