Fix type annotation for gssapi.creds.Credentials name property. Add t…

…est checks. Signed-off-by: Aleksey Kondrator <[email protected]>
pythongssapi · Feb 17, 2025 · 7278672 · 7278672
1 parent ca046f4
commit 7278672
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/gssapi/creds.py b/gssapi/creds.py
@@ -82,9 +82,9 @@ def __new__(
                       super(Credentials, cls).__new__(cls, base_creds))
 
     @property
-    def name(self) -> rnames.Name:
+    def name(self) -> names.Name:
         """Get the name associated with these credentials"""
-        return t.cast(rnames.Name,
+        return t.cast(names.Name,
                       self.inquire(name=True, lifetime=False, usage=False,
                                    mechs=False).name)
 

diff --git a/gssapi/tests/test_high_level.py b/gssapi/tests/test_high_level.py
@@ -224,6 +224,7 @@ def test_inquire(self, str_name, kwargs):
 
         if kwargs['name']:
             self.assertEqual(resp.name, self.name)
+            self.assertIsInstance(resp.name, gssnames.Name)
         else:
             self.assertIsNone(resp.name)
 
@@ -250,6 +251,7 @@ def test_inquire_by_mech(self, str_name, kwargs):
 
         if kwargs['name']:
             self.assertEqual(resp.name, self.name)
+            self.assertIsInstance(resp.name, gssnames.Name)
         else:
             self.assertIsNone(resp.name)