Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove NOT rocm check from gen_ai compile #3126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

acoskunses-AMD
Copy link
Contributor

Enable rocm gen_ai compile by removing NOT Rocm check.

Mentioned cutlass hipify issue resolved via PR #2965

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 0d8dff8
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/66fb1aff6d4f1500085d8124
😎 Deploy Preview https://deploy-preview-3126--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@acoskunses-AMD
Copy link
Contributor Author

@jianyuh @jwfromm

@@ -104,11 +104,6 @@ if(NOT FBGEMM_CPU_ONLY)
add_subdirectory(experimental/gemm)
endif()

if(NOT FBGEMM_CPU_ONLY AND NOT USE_ROCM)
# CUTLASS currently doesn't build on ROCm and CK hasnt yet been added:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is no longer an issue right?

@xw285cornell
Copy link
Contributor

Please rebase and we'll do the import

@jianyuh
Copy link
Member

jianyuh commented Sep 21, 2024

@acoskunses-AMD : Looks like the OSS tests show building errors:

https://github.com/pytorch/FBGEMM/actions/runs/10963754353/job/30445890513?pr=3126

build/experimental/gen_ai/CMakeFiles/fbgemm_gpu_experimental_gen_ai_py.dir/src/quantize/ck_extensions/fbgemm_gpu_experimental_gen_ai_py_generated_fp8_tensorwise_gemm.hip.o.cmake
/__w/FBGEMM/FBGEMM/fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/fp8_tensorwise_gemm.hip:24:10: fatal error: 'ck/utility/blkgemmpipe_scheduler.hpp' file not found
   24 | #include "ck/utility/blkgemmpipe_scheduler.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated when compiling for host.
CMake Error at fbgemm_gpu_experimental_gen_ai_py_generated_fp8_tensorwise_gemm.hip.o.cmake:146 (message):
  Error generating
  /__w/FBGEMM/FBGEMM/fbgemm_gpu/_skbuild/linux-x86_64-3.10/cmake-build/experimental/gen_ai/CMakeFiles/fbgemm_gpu_experimental_gen_ai_py.dir/src/quantize/ck_extensions/./fbgemm_gpu_experimental_gen_ai_py_generated_fp8_tensorwise_gemm.hip.o

@acoskunses-AMD
Copy link
Contributor Author

@xw285cornell @jianyuh

rebased please review.

@jianyuh for compile issue I need to file another PR you might want to merge that one first

@xw285cornell
Copy link
Contributor

@acoskunses-AMD which PR is that?

@acoskunses-AMD
Copy link
Contributor Author

@acoskunses-AMD which PR is that?

I take this back, it seems CK has mentioned headers, with tip of tree things compile.

Maybe CI has an older CK version?

@acoskunses-AMD
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants