Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove args and kwargs from AffineQuantizedTensor #247

Merged
merged 2 commits into from
May 16, 2024

Conversation

jerryzh168
Copy link
Contributor

Summary:
att

Test Plan:
python test/quantization/test_quant_api.py

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented May 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/247

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit e64d4f9 with merge base 9dbdb2b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2024
Copy link
Contributor

@jcaip jcaip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one concern - do we do something like this: https://github.com/pytorch/pytorch/blob/main/torch/sparse/_semi_structured_ops.py#L91

when handling an op like detach? If so we should also update strides there, otherwise it will use default strides.

@jerryzh168
Copy link
Contributor Author

jerryzh168 commented May 16, 2024

just one concern - do we do something like this: pytorch/pytorch@main/torch/sparse/_semi_structured_ops.py#L91

when handling an op like detach? If so we should also update strides there, otherwise it will use default strides.

yeah I can add this to the self.__class__ call for detach

Summary:
att

Test Plan:
python test/quantization/test_quant_api.py

Reviewers:

Subscribers:

Tasks:

Tags:
@jerryzh168 jerryzh168 merged commit 9b25ecc into pytorch:main May 16, 2024
13 checks passed
lancerts pushed a commit to lancerts/ao that referenced this pull request May 17, 2024
Summary:
att

Test Plan:
python test/quantization/test_quant_api.py

Reviewers:

Subscribers:

Tasks:

Tags:
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
Summary:
att

Test Plan:
python test/quantization/test_quant_api.py

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants