[tritonbench] Fix colfax_cutlass flash_attention operator #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
manman-ren
reviewed
Aug 1, 2024
| @@ -128,6 +128,7 @@ class Operator(BenchmarkOperator): | |||
| def __init__(self, tb_args: argparse.Namespace, extra_args: Optional[List[str]] = None): | |||
| super().__init__(tb_args, extra_args) | |||
| args = parse_op_args(self.extra_args) | |||
| self.use_cuda_graphs = False | |||
There was a problem hiding this comment.
I wonder why we need to turn off cuda_graphs.
There was a problem hiding this comment.
It is not about colfax_cutlass, but with ThunderKittens (#2370) mine fails with error:
Caught exception, terminating early with partial results
Traceback (most recent call last):
File "/home/xz/git/benchmark/torchbenchmark/util/triton_op.py", line 558, in run
y_vals: Dict[str, BenchmarkOperatorMetrics] = functools.reduce(
^^^^^^^^^^^^^^^^^
File "/home/xz/git/benchmark/torchbenchmark/util/triton_op.py", line 546, in _reduce_benchmarks
acc[bm_name] = self._do_bench(
^^^^^^^^^^^^^^^
File "/home/xz/git/benchmark/torchbenchmark/util/triton_op.py", line 753, in _do_bench
metrics.latency = triton.testing.do_bench_cudagraph(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/xz/miniconda3/lib/python3.11/site-packages/triton/testing.py", line 46, in do_bench_cudagraph
with torch.cuda.graph(g):
File "/home/xz/miniconda3/lib/python3.11/site-packages/torch/cuda/graphs.py", line 186, in __exit__
self.cuda_graph.capture_end()
File "/home/xz/miniconda3/lib/python3.11/site-packages/torch/cuda/graphs.py", line 84, in capture_end
super().capture_end()
RuntimeError: CUDA error: operation failed due to a previous error during capture
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.
So I am thinking cudagraph might not work with ThunderKittens?
Since it is working with colfax_cutlass, I am reverting this line for this PR.
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
force-pushed
the
xz9/fix-cutlass
branch
from
b5f4ef3 to
b7c6ad7
Compare
xuzhao9
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
xuzhao9
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
approved these changes
Aug 1, 2024
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colfax_cutlass kernels will fail because of C++ template instantiation.
We need to explicitly include the header file to instantiate all template parameters.
Test plan:
Install the colfax_cutlass operators:
Run the flash_attention operator from colfax_cutlass