Skip to content

Commit

Permalink
[ET-VK][ez] Fix 8-bit linear shaders extension requirement (#7607)
Browse files Browse the repository at this point in the history
## Context

8-bit linear compute shaders only require the 8bit_storage extension for buffer tensors. Now that we are checking that the GPU supports required extensions, we need to be more careful about declaring that a extensions as required.

Differential Revision: [D68035429](https://our.internmc.facebook.com/intern/diff/D68035429/)

ghstack-source-id: 260953913
Pull Request resolved: #7600

Co-authored-by: Stephen Jia <[email protected]>
  • Loading branch information
pytorchbot and SS-JIA authored Jan 10, 2025
1 parent 9666ee8 commit 73f50df
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion backends/vulkan/runtime/graph/ops/glsl/q_8w_linear.glsl
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
${define_active_storage_type(STORAGE)}

${define_required_extensions(DTYPE)}
${define_required_extensions("int8")}
$if STORAGE == "buffer":
${define_required_extensions("int8")}

#include "indexing_utils.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
${define_active_storage_type(STORAGE)}

${define_required_extensions(DTYPE)}
${define_required_extensions("int8")}
$if STORAGE == "buffer":
${define_required_extensions("int8")}


$if BATCH_MODE:
Expand Down

0 comments on commit 73f50df

Please sign in to comment.