Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.4.0] Release Tracker #5366

Open
dvorjackz opened this issue Sep 13, 2024 · 116 comments
Open

[v0.4.0] Release Tracker #5366

dvorjackz opened this issue Sep 13, 2024 · 116 comments
Assignees
Milestone

Comments

@dvorjackz
Copy link
Contributor

dvorjackz commented Sep 13, 2024

The v0.4.0 release will be cut from the "release/0.4" branch for critical fixes to the v0.4.0 release.

Branch Cut Date: 09/15/2024
Intended Release Date: 10/17/2024

This issue is for tracking cherry-picks to the release branch.

Cherry-Pick Criteria

Focus on stability and documentation correctness. Ideally only low risk changes may be cherry-picked from main:

  1. Critical fixes in core components: build, exir, backends, runtime, sdk
  2. Bug fixes in demos/examples. No new features/experiments
  3. Critical bug fixes based on community feedback
  4. Documentation improvements
  5. Test/CI fixes
  6. Release branch specific changes (e.g. change version identifiers)

Any core components changes and other change will require special dispensation from the release managers (currently @vmpuri @dvorjackz). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Cherry-Pick Process

  1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

  2. Create (but do not land) a PR against the release branch.
    Option 1: Use pytorchbot to cherry pick a PR that has been committed to the main branch using @pytorchbot cherry-pick command as follows.

    @pytorchbot cherry-pick --onto release/0.4 -c {regression,critical,fixnewfeature,docs,release}
    
    usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                             {regression,critical,fixnewfeature,docs,release}
    
    Cherry pick a pull request onto a release branch for inclusion in a release
    
    optional arguments:
      --onto ONTO           Branch you would like to cherry pick onto (Example: release/0.4)
      --fixes FIXES         Link to the issue that your PR fixes (i.e. https://github.com/pytorch/executorch/issues/2345)
      -c {regression,critical,fixnewfeature,docs,release}
                      A machine-friendly classification of the cherry-pick reason.
                      
    

    Option 2: Manually create a cherry pick PR using git command as follows.

    # Find the hash of the commit you want to cherry pick
    # (for example, abcdef12345)
    git log
    
    git fetch origin release/0.4
    git checkout release/0.4
    git cherry-pick -x abcdef12345
    
    # Submit a PR based against 'release/0.4' either:
    # via the GitHub UI
    git push my-fork
    
    # via the GitHub CLI
    gh pr create --base release/0.4
    
    
  3. Make a request below with the following format:

Link to landed trunk PR:
* 

Link to release branch PR:
* 

Criteria category and reasons:
* 
  1. Someone from the release team will reply with approved / denied or ask for more information.
  2. If approved, someone from the release team will merge your PR once the tests pass. Do not land the release branch PR yourself.

Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD

Versions

0.4.0

@dvorjackz dvorjackz added this to the 0.4.0 milestone Sep 13, 2024
@dbort dbort pinned this issue Sep 14, 2024
@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Fixnewfeature -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Fixnewfeature -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

@pytorchbot
Copy link
Collaborator

pytorchbot commented Sep 16, 2024

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs - Update the devtools tutorial URL to https://pytorch.org/executorch/main/tutorials/devtools-integration-tutorial.html

@pytorchbot
Copy link
Collaborator

pytorchbot commented Sep 17, 2024

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs - Intro and instructions of using benchmarking infra.

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Fixnewfeature -

@pytorchbot
Copy link
Collaborator

pytorchbot commented Sep 17, 2024

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Fixnewfeature - bfloat16 gemm/gemv will go faster on ARM chips with BFDOT (M2 and later Macs, most recentish phones)

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Fixnewfeature -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Fixnewfeature -

@kirklandsign
Copy link
Contributor

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

@pytorchbot
Copy link
Collaborator

pytorchbot commented Sep 18, 2024

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs - Update the devtools overview page URL to https://pytorch.org/executorch/main/devtools-overview.html (used to be ....sdk-overview.html)

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

@digantdesai
Copy link
Contributor

Link to landed trunk PR (if applicable):

  • N/A release branch specific

Link to release branch PR:

Criteria Category:

  • Critical - minimal fix for failing Arm compiler and delegate test as the release branch was taken when this was an a transitional state.

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Fixnewfeature -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Fixnewfeature -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Fixnewfeature -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

This was referenced Oct 9, 2024
@pytorch pytorch deleted a comment from pytorchbot Oct 10, 2024
@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants