Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cadence.aot.passes to cadence.aot._passes #5921

Closed
wants to merge 1 commit into from

Conversation

tarun292
Copy link
Contributor

@tarun292 tarun292 commented Oct 6, 2024

Differential Revision: D63926847

Copy link

pytorch-bot bot commented Oct 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5921

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 216493a with merge base 866b40c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 7, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 7, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 7, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 8, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 8, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
tarun292 added a commit that referenced this pull request Oct 8, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 8, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 8, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 8, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
@tarun292 tarun292 force-pushed the export-D63926847 branch 2 times, most recently from c43cbc2 to 686cedc Compare October 8, 2024 22:14
tarun292 added a commit that referenced this pull request Oct 8, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 8, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 8, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 8, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

tarun292 added a commit that referenced this pull request Oct 9, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser

Differential Revision: D63926847
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser, mcremon-meta

Differential Revision: D63926847
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63926847

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 59c359f.

@tarun292
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c critical

pytorchbot pushed a commit that referenced this pull request Oct 10, 2024
Summary:
Changing cadence.aot.passes to cadence.aot._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5921

Reviewed By: helunwencser, mcremon-meta

Differential Revision: D63926847

fbshipit-source-id: 60c4739a813422b92d2f187fceb5e62f65db6380
(cherry picked from commit 59c359f)
@pytorchbot
Copy link
Collaborator

Cherry picking #5921

The cherry pick PR is at #6091 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants