[pybind] New Runtime pybind API #6063
Open
+416
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6063
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 3e854de with merge base 69c2c76 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
force-pushed
the
new_pybind
branch
from
7a2f796
to
d947f51
Compare
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dbort
requested changes
Oct 9, 2024
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dbort
approved these changes
Oct 10, 2024
larryliu0820
force-pushed
the
new_pybind
branch
from
4a082ff
to
76e678c
Compare
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Summary: Based on this proposal: https://docs.google.com/document/d/10Q4-pt97inQQtFf-FjjwhMaDXXCfk1zGy6V6EkygNUY/edit#heading=h.fcrpnrtb6cud Historically our pybinding APIs are not following the same C++ modeling (Program, Method etc) and hence it's hard to use and easy to hit footguns - for example, if we load the program and return it from a python method, it goes out of the scope and releases the memory. This effort is to create Pybind APIs that resembles C++ objects so it's less confusing to the users. Add the following python classes: * `Runtime`: a singleton object hosting methods like `load_program`. Returns a `Program` object when calling `load_program`. Also exposes the operator registry * `Program`: each pte file should have one `Program` object. Most important method is `load_method` which returns a `Method` object. It has a property `method_names` where we can inspect what methods are inside this .pte file. * `Method`: one object per method name in a given `Program`. Exposes `execute` which takes in pytree flattened torch tensors as input and return pytree flattened output. It also exposes `MethodMeta` for users to inspect more information regarding input/output of this method. Reviewed By: dbort Differential Revision: D64132360 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
new_pybind
branch
from
76e678c
to
bcb1e0e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64132360 |
Summary: Based on this proposal: https://docs.google.com/document/d/10Q4-pt97inQQtFf-FjjwhMaDXXCfk1zGy6V6EkygNUY/edit#heading=h.fcrpnrtb6cud Historically our pybinding APIs are not following the same C++ modeling (Program, Method etc) and hence it's hard to use and easy to hit footguns - for example, if we load the program and return it from a python method, it goes out of the scope and releases the memory. This effort is to create Pybind APIs that resembles C++ objects so it's less confusing to the users. Add the following python classes: * `Runtime`: a singleton object hosting methods like `load_program`. Returns a `Program` object when calling `load_program`. Also exposes the operator registry * `Program`: each pte file should have one `Program` object. Most important method is `load_method` which returns a `Method` object. It has a property `method_names` where we can inspect what methods are inside this .pte file. * `Method`: one object per method name in a given `Program`. Exposes `execute` which takes in pytree flattened torch tensors as input and return pytree flattened output. It also exposes `MethodMeta` for users to inspect more information regarding input/output of this method. Reviewed By: dbort Differential Revision: D64132360 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
new_pybind
branch
from
bcb1e0e
to
3e854de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64132360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Based on this proposal: https://docs.google.com/document/d/10Q4-pt97inQQtFf-FjjwhMaDXXCfk1zGy6V6EkygNUY/edit#heading=h.fcrpnrtb6cud
Historically our pybinding APIs are not following the same C++ modeling
(Program, Method etc) and hence it's hard to use and easy to hit
footguns - for example, if we load the program and return it from a
python method, it goes out of the scope and releases the memory.
This effort is to create Pybind APIs that resembles C++ objects so it's
less confusing to the users.
Add the following python classes:
Runtime: a singleton object hosting methods likeload_program.Returns a
Programobject when callingload_program. Also exposesthe operator registry
Program: each pte file should have oneProgramobject. Mostimportant method is
load_methodwhich returns aMethodobject. Ithas a property
method_nameswhere we can inspect what methods areinside this .pte file.
Method: one object per method name in a givenProgram. Exposesexecutewhich takes in pytree flattened torch tensors as input andreturn pytree flattened output. It also exposes
MethodMetafor usersto inspect more information regarding input/output of this method.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: