Introduce NamedDataStore #8587
Merged
Introduce NamedDataStore #8587
+282
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce NamedDataStore for weight sharing. Rename 'NamedBlobStore' --> 'NamedDataStore' to mirror 'NamedDataMap' in the runtime. The NamedDataStore exposes two methods: - add_named_data: add a blob to the store - get_named_data_store_output: return the contents of the store, to pass to serialization. Invariants on the NamedDataStore - Keys are unique regardless of whether they are in PTE or external file. - Different keys can point to the same data. NamedDataStore is used in D69764150. It's owned by the EdgeProgramManager. Differential Revision: [D69764094](https://our.internmc.facebook.com/intern/diff/D69764094/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8587
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 460e9b1 with merge base 6cb5c1a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69764094 |
lucylq
added a commit
that referenced
this pull request
Feb 19, 2025
Introduce NamedDataStore for weight sharing. Rename 'NamedBlobStore' --> 'NamedDataStore' to mirror 'NamedDataMap' in the runtime. The NamedDataStore exposes two methods: - add_named_data: add a blob to the store - get_named_data_store_output: return the contents of the store, to pass to serialization. Invariants on the NamedDataStore - Keys are unique regardless of whether they are in PTE or external file. - Different keys can point to the same data. NamedDataStore is used in D69764150. It's owned by the EdgeProgramManager. Differential Revision: [D69764094](https://our.internmc.facebook.com/intern/diff/D69764094/) ghstack-source-id: 267278860 Pull Request resolved: #8587
Introduce NamedDataStore for weight sharing. Rename 'NamedBlobStore' --> 'NamedDataStore' to mirror 'NamedDataMap' in the runtime. The NamedDataStore exposes two methods: - add_named_data: add a blob to the store - get_named_data_store_output: return the contents of the store, to pass to serialization. Invariants on the NamedDataStore - Keys are unique regardless of whether they are in PTE or external file. - Different keys can point to the same data. NamedDataStore is used in D69764150. It's owned by the EdgeProgramManager. Differential Revision: [D69764094](https://our.internmc.facebook.com/intern/diff/D69764094/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D69764094 |
lucylq
requested review from
JacobSzwejbka,
tarun292 and
larryliu0820
as code owners
lucylq
added a commit
that referenced
this pull request
Feb 25, 2025
Pull Request resolved: #8587 Introduce NamedDataStore for weight sharing. See 'NamedBlobStore' in [RFC] Rename 'NamedBlobStore' --> 'NamedDataStore' to mirror 'NamedDataMap' in the runtime. The NamedDataStore exposes two methods: - add_named_data: add a blob to the store - get_named_data_store_output: return the contents of the store, to pass to serialization. Invariants on the NamedDataStore - Keys are unique regardless of whether they are in PTE or external file. - Different keys can point to the same data. NamedDataStore is used in D69764150. It's owned by the EdgeProgramManager. ghstack-source-id: 268328940 @exported-using-ghexport Differential Revision: [D69764094](https://our.internmc.facebook.com/intern/diff/D69764094/)
This was referenced Feb 25, 2025
tarun292
approved these changes
Feb 25, 2025
lucylq
added
release notes: api
facebook-github-bot
merged commit 1254145
into
gh/lucylq/43/base
51 of 53 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
swolchok
pushed a commit
that referenced
this pull request
Feb 26, 2025
Pull Request resolved: #8587 Introduce NamedDataStore for weight sharing. See 'NamedBlobStore' in [RFC] Rename 'NamedBlobStore' --> 'NamedDataStore' to mirror 'NamedDataMap' in the runtime. The NamedDataStore exposes two methods: - add_named_data: add a blob to the store - get_named_data_store_output: return the contents of the store, to pass to serialization. Invariants on the NamedDataStore - Keys are unique regardless of whether they are in PTE or external file. - Different keys can point to the same data. NamedDataStore is used in D69764150. It's owned by the EdgeProgramManager. ghstack-source-id: 268328940 @exported-using-ghexport Differential Revision: [D69764094](https://our.internmc.facebook.com/intern/diff/D69764094/)
swolchok
pushed a commit
that referenced
this pull request
Feb 26, 2025
Pull Request resolved: #8587 Introduce NamedDataStore for weight sharing. See 'NamedBlobStore' in [RFC] Rename 'NamedBlobStore' --> 'NamedDataStore' to mirror 'NamedDataMap' in the runtime. The NamedDataStore exposes two methods: - add_named_data: add a blob to the store - get_named_data_store_output: return the contents of the store, to pass to serialization. Invariants on the NamedDataStore - Keys are unique regardless of whether they are in PTE or external file. - Different keys can point to the same data. NamedDataStore is used in D69764150. It's owned by the EdgeProgramManager. ghstack-source-id: 268328940 @exported-using-ghexport Differential Revision: [D69764094](https://our.internmc.facebook.com/intern/diff/D69764094/) Co-authored-by: lucylq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Introduce NamedDataStore for weight sharing.
Rename 'NamedBlobStore' --> 'NamedDataStore' to mirror 'NamedDataMap' in the runtime.
The NamedDataStore exposes two methods:
Invariants on the NamedDataStore
NamedDataStore is used in D69764150. It's owned by the EdgeProgramManager.
Differential Revision: D69764094