Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pass kwargs from make_private to _prepare_optimizer (#648)
Summary: ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Docs change / refactoring / dependency upgrade ## Motivation and Context / Related issue Pass `kwargs` from `make_private` to `_prepare_optimizer` to allow extra arguments to the optimizer. Closes #559 ## How Has This Been Tested (if it applies) Tested and confirmed the [colab notebook](https://colab.research.google.com/drive/1VivVsyU31onR1EAePuQQUMRzGGRgAi94?usp=sharing) in the attached issue works. ## Checklist - [x] The documentation is up-to-date with the changes I made. - [x] I have read the **CONTRIBUTING** document and completed the CLA (see **CONTRIBUTING**). - [x] All tests passed, and additional code has been covered with new tests. Pull Request resolved: #648 Reviewed By: EnayatUllah Differential Revision: D58396361 Pulled By: HuanyuZhang fbshipit-source-id: 64f1b7dfcc3c091702204115ed213887ebd363e9
- Loading branch information