Fix the initialization function of "GradSampleModuleFastGradientClipping" #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62676700 |
|
This pull request was exported from Phabricator. Differential Revision: D62676700 |
HuanyuZhang
added a commit
to HuanyuZhang/opacus
that referenced
this pull request
Sep 21, 2024
…ing" (pytorch#675) Summary: Pull Request resolved: pytorch#675 ``GradSampleModuleFastGradientClipping`` does not correctly take ``strict`` and ``force_functorch`` in its initialization function. Made the fix to allow the change of the values of the two parameters. Differential Revision: D62676700
HuanyuZhang
force-pushed
the
export-D62676700
branch
from
4cc4be9
to
2969227
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62676700 |
HuanyuZhang
force-pushed
the
export-D62676700
branch
from
2969227
to
4c45401
Compare
HuanyuZhang
added a commit
to HuanyuZhang/opacus
that referenced
this pull request
Sep 21, 2024
…ing" (pytorch#675) Summary: Pull Request resolved: pytorch#675 ``GradSampleModuleFastGradientClipping`` does not correctly take ``strict`` and ``force_functorch`` in its initialization function. Made the fix to allow the change of the values of the two parameters. Differential Revision: D62676700
…ing" (pytorch#675) Summary: Pull Request resolved: pytorch#675 ``GradSampleModuleFastGradientClipping`` does not correctly take ``strict`` and ``force_functorch`` in its initialization function. Made the fix to allow the change of the values of the two parameters. Differential Revision: D62676700
|
This pull request was exported from Phabricator. Differential Revision: D62676700 |
HuanyuZhang
force-pushed
the
export-D62676700
branch
from
4c45401
to
b976b9b
Compare
|
This pull request has been merged in aea78b3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
GradSampleModuleFastGradientClippingdoes not correctly takestrictandforce_functorchin its initialization function. Made the fix to allow the change of the values of the two parameters.Differential Revision: D62676700