Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Fix some typos #2811

Merged
merged 2 commits into from
Feb 25, 2025
Merged

[BE] Fix some typos #2811

merged 2 commits into from
Feb 25, 2025

Conversation

antoinebrl
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Feb 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2811

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 9 Pending, 2 Unrelated Failures

As of commit a691e68 with merge base d4f8846 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 25, 2025
@vmoens vmoens added documentation Improvements or additions to documentation quality code quality BE Better errors, logs, docs or test utils labels Feb 25, 2025
@vmoens vmoens changed the title Fix some typos [BE] Fix some typos Feb 25, 2025
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly skimmed through the PR and it all looks good!

@vmoens
Copy link
Contributor

vmoens commented Feb 25, 2025

@antoinebrl seems like the lint is failing :)

@antoinebrl
Copy link
Contributor Author

Thanks for pointing this out!
test/test_transforms.py has been reformatted. CI should be green now!

@vmoens vmoens merged commit 0ae1405 into pytorch:main Feb 25, 2025
71 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE Better errors, logs, docs or test utils CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation quality code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants