Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make torchserve-kfs docker image multiplatform #3162

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Make torchserve-kfs docker image multiplatform #3162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
782c341
Update build_image.sh to build image using buildx and use both arm an…
DanielTemesgen May 25, 2024
3836b54
Merge branch 'master' into kserve-image-multiplatform
DanielTemesgen Jun 5, 2024
006f729
Merge branch 'master' into kserve-image-multiplatform
DanielTemesgen Jun 6, 2024
1f29f11
Merge branch 'master' into kserve-image-multiplatform
DanielTemesgen Jun 8, 2024
576f0a5
Merge branch 'master' into kserve-image-multiplatform
DanielTemesgen Jun 26, 2024
1a2fece
Merge branch 'master' into kserve-image-multiplatform
DanielTemesgen Jul 7, 2024
631bdf2
Merge branch 'master' into kserve-image-multiplatform
DanielTemesgen Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kubernetes/kserve/build_image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,5 @@ fi
cp ../../frontend/server/src/main/resources/proto/*.proto .
cp -r ../../third_party .

DOCKER_BUILDKIT=1 docker build --file "$DOCKER_FILE" --build-arg BASE_IMAGE=$BASE_IMAGE -t "$DOCKER_TAG" .
docker buildx create --name mybuilder --use --bootstrap
docker buildx build --file "$DOCKER_FILE" --build-arg BASE_IMAGE=$BASE_IMAGE --platform linux/amd64,linux/arm64 --push -t "$DOCKER_TAG" .
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command builds and pushes the docker image, so the steps in both python files which push the image have been removed.

6 changes: 0 additions & 6 deletions kubernetes/kserve/build_upload_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@
dry_run,
)

for image in [
f"{organization}/torchserve-kfs:{check_ts_version()}",
f"{organization}/torchserve-kfs:{check_ts_version()}-gpu",
]:
try_and_handle(f"docker push {image}", dry_run)

# Cleanup built images
if args.cleanup:
try_and_handle(f"docker system prune --all --volumes -f", dry_run)
16 changes: 5 additions & 11 deletions kubernetes/kserve/docker_nightly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,16 @@
cpu_version = f"{project}:cpu-{get_nightly_version()}"
gpu_version = f"{project}:gpu-{get_nightly_version()}"

# Build Nightly images and append the date in the name
try_and_handle(f"./build_image.sh -n -t {organization}/{cpu_version}", dry_run)
# Build and push Nightly images and append the date in the name
try_and_handle(
f"./build_image.sh -n -t {organization}/{cpu_version}",
dry_run)
try_and_handle(
f"./build_image.sh -g -n -t {organization}/{gpu_version}",
dry_run,
)

# Push Nightly images to official PyTorch Dockerhub account
try_and_handle(f"docker push {organization}/{cpu_version}", dry_run)
try_and_handle(f"docker push {organization}/{gpu_version}", dry_run)

# Tag nightly images with latest
# Build and push Nightly images with latest
try_and_handle(
f"docker tag {organization}/{cpu_version} {organization}/{project}:latest-cpu",
dry_run,
Expand All @@ -57,10 +55,6 @@
dry_run,
)

# Push images with latest tag
try_and_handle(f"docker push {organization}/{project}:latest-cpu", dry_run)
try_and_handle(f"docker push {organization}/{project}:latest-gpu", dry_run)

# Cleanup built images
if args.cleanup:
try_and_handle(f"docker system prune --all --volumes -f", dry_run)