Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cu125 image to support Ubuntu 24.04 #3281

Closed
wants to merge 0 commits into from

Conversation

jasonsmithio
Copy link

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

I pushed the existing container and saw over 500 CVEs when I scanned the container. Many, if not all, would be addressed if we support Ubuntu 24.04. NVIDA has a docker image running 24.04 as it's base and it runs 12.5.1. I went ahead and added build support for it. As far as I can tell, nothing is broken in this version.

Fixes #3278

Type of change

  • [ x] New feature (non-breaking change which adds functionality)
  • [x ] This change requires a documentation update (maybe)

Feature/Issue validation/testing

No formal unit test. I built the container without error. This one has only 116 vulnerabilities vs 596 in previous version. 2 CVEs are high and he remaining are Medium (97) and Low (17).

Used the container and didn't notice any issues differing from the previous version. I am open to doing more tests if need be.

Checklist:

  • [x ] Did you have fun?
  • [x ] Have you added tests that prove your fix is effective or that this feature works?

@mreso
Copy link
Collaborator

mreso commented Aug 7, 2024

@ankithagunapal do you recall what kind of issues you were facing when updating to 24.04? Otherwise it would be great to move forward with this.

@agunapal
Copy link
Collaborator

@mreso CI / regressions with ubuntu 22 were flaky. Hence we didn't upgrade. Haven't tried that in a while.

@jasonsmithio
Copy link
Author

What exactly were the regression issues? I tested and didn't notice anything out of the ordinary when I deployed this on Ubuntu 24.04

@agunapal
Copy link
Collaborator

What exactly were the regression issues? I tested and didn't notice anything out of the ordinary when I deployed this on Ubuntu 24.04

@jasonsmithio The workflows you see in this file, you can try updating them to ubuntu 22 or 24 (atleast the CPU ones) . For CUDA versions, we follow PyTorch, So first step would be to support 12.4 , Python version too, we could try updating to 3.10 first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for a CUDA 12.5.x
3 participants