[Test] Fix as_tensor test (#551)

pytorch · Nov 2, 2023 · 9865dec · 9865dec
1 parent 09b327c
commit 9865dec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.github/unittest/linux/scripts/install.sh b/.github/unittest/linux/scripts/install.sh
@@ -47,7 +47,10 @@ printf "* Installing tensordict\n"
 python setup.py develop
 
 # install torchsnapshot nightly
-python -m pip install git+https://github.com/pytorch/torchsnapshot --no-build-isolation
-
+if [[ "$TORCH_VERSION" == "nightly" ]]; then
+  python -m pip install git+https://github.com/pytorch/torchsnapshot --no-build-isolation
+elif [[ "$TORCH_VERSION" == "stable" ]]; then
+  python -m pip install torchsnapshot
+fi
 # smoke test
 python -c "import functorch;import torchsnapshot"
diff --git a/test/test_tensordict.py b/test/test_tensordict.py
@@ -2283,8 +2283,8 @@ def test_as_tensor(self, td_name, device):
             ):
                 td.as_tensor()
         else:
-            with pytest.raises(AttributeError):
-                td.as_tensor()
+            # checks that it runs
+            td.as_tensor()
 
     def test_items_values_keys(self, td_name, device):
         torch.manual_seed(1)