move out zero grad logic into separate function #969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68983117 |
Summary:
# Context
Currently it isn't possible to log gradients from AutoUnit as they are zeroed out before `on_train_step_end()` is reached.
# This Diff
Moves out the zeroed grad from the `_update_weights` and into it's own function. Can be overridden, ie
```
class MyAutoUnit(AutoUnit):
...
def zero_grad(self) ->
self.logger.log(self.module.grad)
super().zero_grad()
```
to log the gradients prior to zeroing them out
Reviewed By: galrotem, diego-urgell
Differential Revision: D68983117
JKSenthil
force-pushed
the
export-D68983117
branch
from
d5eb55b to
988a39e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68983117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Currently it isn't possible to log gradients from AutoUnit as they are zeroed out before
on_train_step_end()is reached.This Diff
Moves out the zeroed grad from the
_update_weightsand into it's own function. Can be overridden, ieto log the gradients prior to zeroing them out
Reviewed By: galrotem
Differential Revision: D68983117