Expose mixed_precision dtype arguments #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2024
Merged
facebook-github-bot
added
the
CLA Signed
Closed
tianyu-l
reviewed
May 20, 2024
kwen2501
approved these changes
May 20, 2024
torchtitan/config_manager.py
Outdated
| TORCH_DTYPE_ARGS = [ | ||
| "checkpoint.export_dtype", | ||
| "training.mixed_precision_param", | ||
| "training.mixed_precision_reduce", |
There was a problem hiding this comment.
nit: should "reduce" be "grad"?
There was a problem hiding this comment.
no, im following the existing naming for the mixed_precision config struct
Comment on lines
+244
to
+245
| torch dtype to use for reductions when applying mixed precision via FSDP. | ||
| This feature only takes effect when data_parallel_degree > 1 |
There was a problem hiding this comment.
nit: "reductions" -> "gradients"
torchtitan/config_manager.py
Outdated
Comment on lines
403
to
405
| for k_, v_ in v.items(): | ||
| if ".".join([k, k_]) in TORCH_DTYPE_ARGS: | ||
| v[k_] = torch_dtype(v_) |
wconstab
added a commit
that referenced
this pull request
May 21, 2024
add training.mixed_precision_param and .mixed_precision_reduce options refactor a util to map strings to torch dtypes ghstack-source-id: 387e1ca13ad23e859d21d7760f858ee6e269a796 Pull Request resolved: #348
tianyu-l
pushed a commit
that referenced
this pull request
May 28, 2024
add training.mixed_precision_param and .mixed_precision_reduce options refactor a util to map strings to torch dtypes ghstack-source-id: 387e1ca13ad23e859d21d7760f858ee6e269a796 Pull Request resolved: #348
tianyu-l
pushed a commit
to tianyu-l/torchtitan_intern24
that referenced
this pull request
Aug 16, 2024
add training.mixed_precision_param and .mixed_precision_reduce options refactor a util to map strings to torch dtypes ghstack-source-id: 387e1ca13ad23e859d21d7760f858ee6e269a796 Pull Request resolved: pytorch#348
tianyu-l
pushed a commit
that referenced
this pull request
Aug 16, 2024
add training.mixed_precision_param and .mixed_precision_reduce options refactor a util to map strings to torch dtypes ghstack-source-id: 387e1ca13ad23e859d21d7760f858ee6e269a796 Pull Request resolved: #348
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
add training.mixed_precision_param and .mixed_precision_reduce options refactor a util to map strings to torch dtypes ghstack-source-id: 387e1ca13ad23e859d21d7760f858ee6e269a796 Pull Request resolved: pytorch#348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
add training.mixed_precision_param and .mixed_precision_reduce options
refactor a util to map strings to torch dtypes