Retrieve schedules from get_schedule_class() #595
+19
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
H-Huang
added a commit
that referenced
this pull request
Oct 1, 2024
ghstack-source-id: 8abfc98eb138e904749b632dc4250ee9da79314f Pull Request resolved: #595
facebook-github-bot
added
the
CLA Signed
tianyu-l
reviewed
Oct 3, 2024
torchtitan/config_manager.py
Outdated
| @@ -299,14 +299,14 @@ def __init__(self): | |||
| self.parser.add_argument( | |||
| "--experimental.pipeline_parallel_schedule", | |||
| type=str, | |||
| choices=["1f1b", "gpipe", "interleaved_1f1b", "flexible_interleaved_1f1b"], | |||
| choices=["1f1b", "gpipe", "Interleaved1F1B", "FlexibleInterleaved1F1B"], | |||
There was a problem hiding this comment.
any reason we leave 1f1b and gpipe in lower cases?
There was a problem hiding this comment.
The get_schedule() method is case insensitive, the main change was i needed to remove the "_" in the other schedules. But I can change these as well for consistency.
Removes glue code and allow users to pass in schedule arg as a string without updating titan. Depends on pytorch/pytorch#137103 [ghstack-poisoned]
XilunWu
approved these changes
Oct 8, 2024
tianyu-l
reviewed
Oct 8, 2024
| @@ -299,14 +299,14 @@ def __init__(self): | |||
| self.parser.add_argument( | |||
| "--experimental.pipeline_parallel_schedule", | |||
| type=str, | |||
| choices=["1f1b", "gpipe", "interleaved_1f1b", "flexible_interleaved_1f1b"], | |||
| default="1f1b", | |||
| choices=["1F1B", "Gpipe", "Interleaved1F1B", "FlexibleInterleaved1F1B"], | |||
There was a problem hiding this comment.
very tiny nit: GPipe instead of Gpipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Removes glue code and allow users to pass in schedule arg as a string without updating titan.
Depends on pytorch/pytorch#137103