[MoE][PoC] Expert Parallel: tp and tp2ep #731
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Dec 12, 2024
ghstack-source-id: 5e173f32cc2162feb063f58d9c85ad821c325770 Pull Request resolved: #731
facebook-github-bot
added
the
CLA Signed
Issues (12/11/2024)
- forward collectives look right ("tp2ep" AG -> compute -> RS), need to understand the backward better
- torch.compile generates full graph (applied per TransformerBlock), but inserts an additional A2A at the end of every two blocks
Haven't worked on
- softmax scoring when Router Parallel is used (currently only sigmoid)
[ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Issues (12/11/2024)
Not including