Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quant][pt2e] Add documentation for pt2 export static quant #2504

Merged
merged 13 commits into from
Jul 28, 2023

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jul 14, 2023

Stack from ghstack (oldest at bottom):

Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

cc @jianyuh

Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2504

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9e3850d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jerryzh168 added a commit that referenced this pull request Jul 14, 2023
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 46c2e8a23b1a6e6227d819d44d707aa23c897ea4
Pull Request resolved: #2504
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few editorial suggestions. Can you please also add pt2e_quant_ptq_static to https://github.com/pytorch/tutorials/blob/main/prototype_source/prototype_index.rst

prototype_source/pt2e_quant_ptq_static.rst Outdated Show resolved Hide resolved
prototype_source/pt2e_quant_ptq_static.rst Outdated Show resolved Hide resolved
prototype_source/pt2e_quant_ptq_static.rst Show resolved Hide resolved
prototype_source/pt2e_quant_ptq_static.rst Outdated Show resolved Hide resolved
prototype_source/pt2e_quant_ptq_static.rst Outdated Show resolved Hide resolved
prototype_source/pt2e_quant_ptq_static.rst Outdated Show resolved Hide resolved
prototype_source/pt2e_quant_ptq_static.rst Outdated Show resolved Hide resolved
prototype_source/pt2e_quant_ptq_static.rst Outdated Show resolved Hide resolved
prototype_source/pt2e_quant_ptq_static.rst Outdated Show resolved Hide resolved
prototype_source/pt2e_quant_ptq_static.rst Outdated Show resolved Hide resolved
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 15, 2023
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e095f0dc16dc8b1f0ce06cf7dd5f5d031851e198
Pull Request resolved: #2504
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 20, 2023
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 8a5653e65cefcb7d6c2e251a2dc1191c0a5deb20
Pull Request resolved: #2504
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 25, 2023
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6d1ab4f765adace8043acd0baed60de8f98f8070
Pull Request resolved: #2504
@jerryzh168 jerryzh168 requested a review from svekars July 25, 2023 23:55
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 26, 2023
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1d7c13e8fa82da770edb62fb6ccc99ac3fae74a4
Pull Request resolved: #2504
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 26, 2023
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 17a032680643dcd017fe357c1320093f9613cc66
Pull Request resolved: #2504
Copy link

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping to unblock

@jerryzh168
Copy link
Contributor Author

@pytorchbot rebase

Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 27, 2023
Summary:
att

Test Plan:
visual inspection

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 97a24667438a72af607809cbfd6141d99f49ada8
Pull Request resolved: #2504
**Author**: `Jerry Zhang <https://github.com/jerryzh168>`_

This tutorial introduces the steps to do post training static quantization in graph mode based on
`torch._export.export <https://pytorch.org/docs/main/export.html>`_. Compared to `FX Graph Mode Quantization <https://pytorch.org/tutorials/prototype/fx_graph_mode_ptq_static.html>`, this flow is expected to have significantly higher model coverage (`88% on 14K models <https://github.com/pytorch/pytorch/issues/93667#issuecomment-1601171596>`), better programmability, and a simplified UX.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svekars looks like you are making some final updates, could you add _ to "FX Graph Mode Quantization <https://pytorch.org/tutorials/prototype/fx_graph_mode_ptq_static.html>" as well?

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to unblock. Will submit a follow-up PR with formatting corrections.

@svekars svekars merged commit da2e2ca into gh/jerryzh168/2/base Jul 28, 2023
18 checks passed
@svekars svekars deleted the gh/jerryzh168/2/head branch July 28, 2023 16:08
@svekars svekars restored the gh/jerryzh168/2/head branch July 28, 2023 17:28
@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/2/head branch August 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants