-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial inductor on Windows CPU #3062
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3062
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 319c395 with merge base 01d2270 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Can you please add to the https://github.com/pytorch/tutorials/blob/main/prototype_source/prototype_index.rst so it's included in the toctree. |
have done so |
Hi @svekars , I have add a new section to complete the tutorial and also add the tutorial to prototype_index.rst |
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please file an issue and follow-up with an update once you have the intel compiler blog link
.. code-block:: sh | ||
|
||
"C:/ProgramData/miniforge3/Scripts/activate.bat" | ||
#. Create and activate a customer conda environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be "custom" conda environment, shouldn't it?
opt_foo1 = torch.compile(foo) | ||
print(opt_foo1(torch.randn(10, 10), torch.randn(10, 10))) | ||
|
||
The code above returns the following output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would not, would it? As inputs are random
def foo(x, y): | ||
a = torch.sin(x) | ||
b = torch.cos(x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If function takes two arguments, should 2nd one be used somewhere? (i.e. y
argument is currently unused in the codebase, is it?)
@ZhaoqiongZ let's create another PR to fix @malfet 's comments, after national holiday. |
svekars has fixed all of it with pr #3071 |
Add tutorial inductor on Windows CPU
CC: @jgong5