change torch.cuda.amp.GradScaler to torch.GradScaler("cuda") #3257
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3257
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @0ssamaak0! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
recipes_source/recipes/amp_recipe.py
Outdated
| @@ -182,7 +182,7 @@ def make_model(in_size, out_size, num_layers): | |||
|
|
|||
| net = make_model(in_size, out_size, num_layers) | |||
| opt = torch.optim.SGD(net.parameters(), lr=0.001) | |||
| scaler = torch.cuda.amp.GradScaler(enabled=use_amp) | |||
| scaler = torch.GradScaler("cuda" ,enabled=use_amp) | |||
There was a problem hiding this comment.
Thanks for the quick reply. GradScaler can be used on its own but because you are modifying amp recipe, I would suggest to use torch.amp.GradScaler as it's also mentioned in the code - https://github.com/pytorch/pytorch/blob/main/torch/cuda/amp/grad_scaler.py#L12
Also, if you run the recipe, you will notice the warning message suggesting to use torch.amp.GradScaler
There was a problem hiding this comment.
I have changed the code accordingly.
Thank you
Description
using
torch.cuda.amp.GradScalerwill result in a warningSo it should be changed according to Automatic Mixed Precision package Documentation
torch.cuda.amp.GradScalertotorch.GradScaler("cuda")to matchChecklist