Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detail to type for functional.to_tensor pic #8449

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add detail to type for functional.to_tensor pic #8449

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
161f625
Add detail to type for functional.to_tensor pic
adamtheturtle May 29, 2024
4f56ec2
Fix closing bracket
NicolasHug May 29, 2024
78d4089
Do not specify the dimensions in to_tensor pic type hint
adamtheturtle Jun 27, 2024
3086f67
Merge branch 'main' into patch-1
adamtheturtle Jun 27, 2024
93a30c3
Merge branch 'main' into patch-1
NicolasHug Jul 29, 2024
bb8bb16
Expand type of to_tensor to allow pic to be an array of np.float32
adamtheturtle Jul 29, 2024
f6fe959
Move import to satisfy linter
adamtheturtle Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torchvision/transforms/functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
return img.ndim in {2, 3}


def to_tensor(pic: Union[PILImage, np.ndarray]) -> Tensor:
def to_tensor(pic: Union[PILImage, np.ndarray[int, int]]) -> Tensor:

Check warning on line 127 in torchvision/transforms/functional.py

View workflow job for this annotation

GitHub Actions / bc 

Function to_tensor: pic changed from Union[PILImage, np.ndarray] to Union[PILImage, np.ndarray[int, int]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamtheturtle thanks for the PR - just to make sure I understand correctly, does np.ndarray[int, int] mean the ndarry is expected to only have 2 dimensions? If that's the case then that is not correct as we allow both 2D and 3D arrays.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @NicolasHug for leaving this hanging. I have had another go, and not specified the dimensions. I have also used numpy.typing.NDArray.

"""Convert a ``PIL Image`` or ``numpy.ndarray`` to tensor.
This function does not support torchscript.

Expand Down
Loading