Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception when no network #52

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TAlonglong
Copy link
Contributor

Handle exception and check if address recevier has started if network is missing

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #52 (4165376) into main (14d84af) will increase coverage by 0.90%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   78.75%   79.65%   +0.90%     
==========================================
  Files          14       15       +1     
  Lines        2099     2168      +69     
==========================================
+ Hits         1653     1727      +74     
+ Misses        446      441       -5     
Impacted Files Coverage Δ
posttroll/address_receiver.py 96.77% <100.00%> (+0.80%) ⬆️
posttroll/ns.py 95.60% <100.00%> (+0.14%) ⬆️
posttroll/tests/test_pubsub.py 96.74% <100.00%> (+0.12%) ⬆️
posttroll/__init__.py 88.09% <0.00%> (ø)
posttroll/version.py 39.54% <0.00%> (+2.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TAlonglong
Copy link
Contributor Author

I think this solve the issue. Not sure if the refactor caused more issues than it solved.

But the tests does not complete it seems.

What do you think

@mraspaud
Copy link
Member

mraspaud commented May 8, 2023

Are the tests running locally? It seems to be working with python 3.10 at least, but I cannot see why your changing might be causing the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants