Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Landsat reader for compatibility with Pyspectral. #2938

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Oct 17, 2024

The Landsat reader used different nomenclature for the band names to that used by Pyspectral. This PR updates the reader for compatibility with the pyspectral LUTs.

Note: Only Landsat-8 is supported by pyspectral at present, and the thermal bands are not included. A separate PR for pyspectral will include both thermal and Landsat-9 support.

  • Tests added

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (dce15c3) to head (21d80ab).
Report is 186 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2938    +/-   ##
========================================
  Coverage   96.11%   96.11%            
========================================
  Files         377      377            
  Lines       54931    55075   +144     
========================================
+ Hits        52796    52937   +141     
- Misses       2135     2138     +3     
Flag Coverage Δ
behaviourtests 3.95% <0.00%> (-0.01%) ⬇️
unittests 96.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11384238269

Details

  • 57 of 57 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.213%

Totals Coverage Status
Change from base Build 11381112172: 0.0%
Covered Lines: 53175
Relevant Lines: 55268

💛 - Coveralls

@mraspaud mraspaud merged commit 936e469 into pytroll:main Oct 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants