Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore contentless lesson directories #16

Merged
merged 6 commits into from
Jan 10, 2020
Merged

Ignore contentless lesson directories #16

merged 6 commits into from
Jan 10, 2020

Conversation

encukou
Copy link
Member

@encukou encukou commented Jan 6, 2020

Fixes: #15

encukou added 3 commits January 6, 2020 15:29
@encukou
Update install and test instructions
695e121 
Use venv, not pipenv, for this library.
@encukou
Adjust Travis CI config to match README
15aa7de
@encukou
Canonical lessons: Ignore directories without info.yml
b8f2e99 
Directories without lesson info can stay around when switching
branches if temporary files are present. In particular,
Jupyter likes to create `.ipynb_checkpoints` directories when
editing notebooks.

Fixes: pyvec#15
@encukou encukou requested a review from frenzymadness January 6, 2020 14:40
@encukou encukou force-pushed the ignore-contentless branch 4 times, most recently from fa21a1e to 5f8d3ba Compare January 6, 2020 15:37
@encukou
Travis CI: Remove OS X tests
6dfe32f 
I can't figure out how to install Python 3 on OS X on Travis.
@encukou encukou force-pushed the ignore-contentless branch from 5f8d3ba to 6dfe32f Compare January 6, 2020 15:53
@hroncok
Copy link
Member

hroncok commented Jan 6, 2020

@encukou
Copy link
Member Author

encukou commented Jan 6, 2020 •
edited
Loading

Sorry for the mess.
I skipped OS X tests because I can't figure out how to handle Homebrew's switch to Python 3. Will track that here: #17

@encukou encukou mentioned this pull request Jan 6, 2020
Merged
frenzymadness
frenzymadness previously requested changes Jan 7, 2020
View reviewed changes
Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found just one small typo. The diff looks good to me and it seems to work well and fix the issue with an empty folder.
Do not forget to change the version to 1.3 also in setup.py.

test_naucse_render/fixtures/test_content/lessons/testcases/ignored_lesson/README Outdated Show resolved Hide resolved
@encukou
Copy link
Member Author

encukou commented Jan 7, 2020

Do not forget to change the version to 1.3 also in setup.py.

I'm planning to release with #12. Or do you want to start using this now?

@encukou @frenzymadness
Update comment
1a132a8 
Co-Authored-By: Lumír 'Frenzy' Balhar <[email protected]>
@frenzymadness
Copy link
Member

I'm planning to release with #12. Or do you want to start using this now?

Not right now. We still have more than a week before we start deploying the PyData courses.

@encukou encukou merged commit 9a86d4c into pyvec:master Jan 10, 2020
@encukou encukou deleted the ignore-contentless branch January 10, 2020 10:21
@encukou
Copy link
Member Author

encukou commented Jan 10, 2020 •
edited
Loading

I Merged this with the wrong commit message :(
But it's in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenzymadness frenzymadness frenzymadness left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with existing lesson without actual content
3 participants
@encukou @hroncok @frenzymadness