Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always check for lowercase component type #230

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Always check for lowercase component type #230

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18139e3
Always check for lowercase component type
s-simoncelli Feb 19, 2024
a7c3641
Merge branch 'main' into fix-node-style
s-simoncelli Feb 19, 2024
d8d55ba
Merge branch 'main' into fix-node-style
s-simoncelli Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pywr_editor/model/component_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def type(self) -> str | None:
:return: The lowercase string identifying the component type.
"""
if "type" in self.props and self.props["type"]:
return self.props["type"]
return self.props["type"].lower()
return None

@property
Expand Down
Loading