-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further improvements to EBSD detector functionality #714
base: develop
Are you sure you want to change the base?
Further improvements to EBSD detector functionality #714
Conversation
Signed-off-by: Håkon Wiik Ånes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tgwoodcock, is this OK with you? Please suggest any additional info or changes you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @hakonanes! It looks fine and I'd just like to add the ROR address for my institute to the end of the "affiliation" line: (ROR: https://ror.org/04zb59n70)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fine too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, thank you.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #714 +/- ##
==========================================
Coverage ? 98.14%
==========================================
Files ? 94
Lines ? 7337
Branches ? 990
==========================================
Hits ? 7201
Misses ? 50
Partials ? 86 ☔ View full report in Codecov by Sentry. |
Description of the change
#709
Progress of the PR
Minimal example of the bug fix or new feature
Will add in future.
For reviewers
__init__.py
.section in
CHANGELOG.rst
.kikuchipy/__init__.py
and.zenodo.json
.