Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements to EBSD detector functionality #714

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hakonanes
Copy link
Member

Description of the change

#709

Progress of the PR

Minimal example of the bug fix or new feature

Will add in future.

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to kikuchipy/__init__.py and .zenodo.json.

@hakonanes hakonanes added enhancement New feature or request documentation This relates to the documentation maintenance This relates to package maintenance labels Jan 1, 2025
@hakonanes hakonanes added this to the v0.12.0 milestone Jan 1, 2025
@hakonanes hakonanes marked this pull request as draft January 1, 2025 16:12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgwoodcock, is this OK with you? Please suggest any additional info or changes you'd like.

Copy link
Contributor

@tgwoodcock tgwoodcock Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hakonanes! It looks fine and I'd just like to add the ROR address for my institute to the end of the "affiliation" line: (ROR: https://ror.org/04zb59n70)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fine too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, thank you.

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@7d1dbaa). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #714   +/-   ##
==========================================
  Coverage           ?   98.14%           
==========================================
  Files              ?       94           
  Lines              ?     7337           
  Branches           ?      990           
==========================================
  Hits               ?     7201           
  Misses             ?       50           
  Partials           ?       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This relates to the documentation enhancement New feature or request maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants