Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the code more modern #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make the code more modern #7

wants to merge 1 commit into from

Conversation

hecko
Copy link

@hecko hecko commented Jan 24, 2018

  • migrate to python3
  • fix indentation
  • fix pyzabbix class init

 * fix all of the indentation inconsistencies
 * still needs a lot of refactoring for pretty codestyling
@arrfab
Copy link

arrfab commented Jan 24, 2018

I'm not the author, but wondering why forcing a switch to python3 while quite a few distributions are still on python2. Using myself some of those scripts for the CentOS infra, and python 2.7 is still the default (and only one in base distro) for CentOs 7 (and let's not even mention python 2.6 on CentOS 6)

Of course that will be @q1x's decision, but that would mean that suddenly some people would have to revert those changes (into a different branch ?)

@hecko
Copy link
Author

hecko commented Jan 24, 2018

Well because Pyhton 2 might become depricated very quickly (https://pythonclock.org) and also because RHEL 8 will not suport Python 2 any more. Also these scripts are not primarily intended to be run regularly on the production infrastructure itself, rather run on dev systems where Im sure you can afford installing Python 3 from EPEL. Just my two cents.

@geekpete
Copy link

Can't it be made to run on both 2.7 and 3?
https://docs.python.org/3/howto/pyporting.html

Many packages on Pypi work on both:
https://python3wos.appspot.com/

@ironbishop
Copy link

is there anyone out there? python2 is deprecated by now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants