Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility for vehicles.lua #1051

Closed
wants to merge 3 commits into from
Closed

Backwards compatibility for vehicles.lua #1051

wants to merge 3 commits into from

Conversation

xDope7137
Copy link

Description

you can just drag and drop the vehicles from older vehicles.lua now

Checklist

  • [x ] I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

you can just drag and drop the vehicles from older vehicles.lua now
@xDope7137
Copy link
Author

xDope7137 commented Dec 6, 2023

bad idea https://stackoverflow.com/questions/71276468/what-is-the-fastest-way-to-go-through-an-array-table-with-numeric-indices

buddy read the whole topic. they are enumerating 100,000+ values. People do not have more than 500 vehicles in that file.

by that logic, nothing should be using pairs. It does not sense to make it work for all small sized tables.

Besides, are you going to let all server owners to convert their whole car tables to new layout? To save 0.2ms compute time? Just one time every restart? smh

@xDope7137
Copy link
Author

image

@MoskalykA
Copy link
Contributor

MoskalykA commented Dec 7, 2023

I'm just offering my opinion

Copy link

github-actions bot commented Feb 5, 2024

This PR has had 60 days of inactivity & will close within 7 days

@github-actions github-actions bot added the Stale label Feb 5, 2024
@xDope7137
Copy link
Author

qb dead?

@github-actions github-actions bot removed the Stale label Feb 8, 2024
Copy link

github-actions bot commented Apr 9, 2024

This PR has had 60 days of inactivity & will close within 7 days

@github-actions github-actions bot added the Stale label Apr 9, 2024
@xDope7137
Copy link
Author

qb dead dead

@github-actions github-actions bot removed the Stale label Apr 11, 2024
@GhzGarage GhzGarage closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants